Issue 84363002: Minor c/b/ui/views/infobars changes:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 84363002: Minor c/b/ui/views/infobars changes: (Closed)

Created:
7 years, 1 month ago by Peter Kasting

Modified:
7 years ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Minor c/b/ui/views/infobars changes: * Make the various translate OptionsMenuModels scoped_ptr<>s like the other menu models. This is mostly for convenience for the refactor change, where accessing the delegate (to initialize this) in the constructor is kind of annoying. Added bonus, we can pull a few #includes out of some .h files. * Add a blank line between blocks of forward declarations... this seems to be how most other code does it and feels a little less cramped BUG=none TEST=none TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236932

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -12 lines)			Patch
M	chrome/browser/ui/views/infobars/after_translate_infobar.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/after_translate_infobar.cc	View	4 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/before_translate_infobar.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/before_translate_infobar.cc	View	4 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/extension_infobar.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/infobar_view.h	View	2 chunks	+2 lines, -1 line	1 comment	Download
M	chrome/browser/ui/views/infobars/translate_language_menu_model.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

https://codereview.chromium.org/84363002/diff/1/chrome/browser/ui/views/infobars/infobar_view.h File chrome/browser/ui/views/infobars/infobar_view.h (right): https://codereview.chromium.org/84363002/diff/1/chrome/browser/ui/views/infobars/infobar_view.h#newcode31 chrome/browser/ui/views/infobars/infobar_view.h:31: } // namespace views I added this because the ...

7 years, 1 month ago (2013-11-23 02:49:38 UTC) #1

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages