content/public/browser/content_browser_client.h - Issue 843583005: [ServiceWorker] Implement WebServiceWorkerContextClient::openWindow().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/content_browser_client.h

Issue 843583005: [ServiceWorker] Implement WebServiceWorkerContextClient::openWindow(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@content_browser_client_openurl

Patch Set: jochen review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/common/service_worker/service_worker_messages.h ('k') | content/public/browser/content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/content_browser_client.h

diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h

index c2f5343954bf648ff7002b2e0c7c4683f93f71c8..8753e0c19577913c0b3bcc74807695f9def1d5c5 100644

--- a/content/public/browser/content_browser_client.h

+++ b/content/public/browser/content_browser_client.h

@@ -105,6 +105,7 @@ class SpeechRecognitionManagerDelegate;

class WebContents;

class WebContentsViewDelegate;

struct MainFunctionParams;

+struct OpenURLParams;

struct Referrer;

struct WebPreferences;

@@ -595,6 +596,11 @@ class CONTENT_EXPORT ContentBrowserClient {

RenderFrameHost* render_frame_host,

blink::WebPageVisibilityState* visibility_state) {}

+ // Allows programmatic opening of a new tab/window without going through

+ // another WebContents. For example, from a Worker.

+ virtual WebContents* OpenURL(BrowserContext* browser_context,

+ const OpenURLParams& params);

#if defined(OS_POSIX) && !defined(OS_MACOSX)

// Populates |mappings| with all files that need to be mapped before launching

// a child process.