content/common/service_worker/service_worker_messages.h - Issue 843583005: [ServiceWorker] Implement WebServiceWorkerContextClient::openWindow().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 843583005: [ServiceWorker] Implement WebServiceWorkerContextClient::openWindow(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@content_browser_client_openurl

Patch Set: jochen review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/browser/service_worker/service_worker_version.cc ('k') | content/public/browser/content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index 986fd8b10252f740d5f9179501bceceaf878ce52..a25bd99eb7fe9b6c84630b7a1b360139f3ea3b17 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -216,6 +216,11 @@ IPC_MESSAGE_ROUTED3(ServiceWorkerHostMsg_PostMessageToDocument,

base::string16 /* message */,

std::vector<int> /* sent_message_port_ids */)

+// Ask the browser to open a tab/window (renderer->browser).

+IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_OpenWindow,

+ int /* request_id */,

+ GURL /* url */)

// Ask the browser to focus a client (renderer->browser).

IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_FocusClient,

int /* request_id */,

@@ -426,6 +431,15 @@ IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_DidGetClientDocuments,

int /* request_id */,

std::vector<content::ServiceWorkerClientInfo>)

+// Sent via EmbeddedWorker as a response of OpenWindow.

+IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_OpenWindowResponse,

+ int /* request_id */,

+ content::ServiceWorkerClientInfo /* client */)

+// Sent via EmbeddedWorker as an error response of OpenWindow.

+IPC_MESSAGE_CONTROL1(ServiceWorkerMsg_OpenWindowError,

+ int /* request_id */ )

// Sent via EmbeddedWorker as a response of FocusClient.

IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_FocusClientResponse,

int /* request_id */,