Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 843513002: make check failures unlikely (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

make check failures unlikely BUG= Committed: https://crrev.com/cc538447964503226f38503f34d46aed8add52b1 Cr-Commit-Position: refs/heads/master@{#25976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M src/base/logging.h View 9 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-07 13:57:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843513002/1
5 years, 11 months ago (2015-01-07 13:57:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 14:40:45 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 14:40:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc538447964503226f38503f34d46aed8add52b1
Cr-Commit-Position: refs/heads/master@{#25976}

Powered by Google App Engine
This is Rietveld 408576698