make check failures unlikely

src/base/logging.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_BASE_LOGGING_H_
 #define V8_BASE_LOGGING_H_
 
 #include <stdint.h>
 #include <string.h>
 
@@ skipping 15 matching lines @@
 #define FATAL(msg)                              \
   V8_Fatal("", 0, "%s", (msg))
 #define UNIMPLEMENTED()                         \
   V8_Fatal("", 0, "unimplemented code")
 #define UNREACHABLE() ((void) 0)
 #endif
 
 
 // The CHECK macro checks that the given condition is true; if not, it
 // prints a message to stderr and aborts.
-#define CHECK(condition) do {                                       \
-    if (!(condition)) {                                             \
+#define CHECK(condition)                                            \
+  do {                                                              \
+    if (V8_UNLIKELY(!(condition))) {                                \
       V8_Fatal(__FILE__, __LINE__, "CHECK(%s) failed", #condition); \
     }                                                               \
   } while (0)
 
 
 // Helper function used by the CHECK_EQ function when given int
 // arguments.  Should not be called directly.
 inline void CheckEqualsHelper(const char* file, int line,
                               const char* expected_source, int expected,
                               const char* value_source, int value) {
-  if (expected != value) {
+  if (V8_UNLIKELY(expected != value)) {
     V8_Fatal(file, line,
              "CHECK_EQ(%s, %s) failed\n#   Expected: %i\n#   Found: %i",
              expected_source, value_source, expected, value);
   }
 }
 
 
 // Helper function used by the CHECK_EQ function when given int64_t
 // arguments.  Should not be called directly.
 inline void CheckEqualsHelper(const char* file, int line,
                               const char* expected_source,
                               int64_t expected,
                               const char* value_source,
                               int64_t value) {
-  if (expected != value) {
+  if (V8_UNLIKELY(expected != value)) {
     // Print int64_t values in hex, as two int32s,
     // to avoid platform-dependencies.
     V8_Fatal(file, line,
              "CHECK_EQ(%s, %s) failed\n#"
              "   Expected: 0x%08x%08x\n#   Found: 0x%08x%08x",
              expected_source, value_source,
              static_cast<uint32_t>(expected >> 32),
              static_cast<uint32_t>(expected),
              static_cast<uint32_t>(value >> 32),
              static_cast<uint32_t>(value));
   }
 }
 
 
 // Helper function used by the CHECK_NE function when given int
 // arguments.  Should not be called directly.
 inline void CheckNonEqualsHelper(const char* file,
                                  int line,
                                  const char* unexpected_source,
                                  int unexpected,
                                  const char* value_source,
                                  int value) {
-  if (unexpected == value) {
+  if (V8_UNLIKELY(unexpected == value)) {
     V8_Fatal(file, line, "CHECK_NE(%s, %s) failed\n#   Value: %i",
              unexpected_source, value_source, value);
   }
 }
 
 
 // Helper function used by the CHECK function when given string
 // arguments.  Should not be called directly.
 inline void CheckEqualsHelper(const char* file,
                               int line,
                               const char* expected_source,
                               const char* expected,
                               const char* value_source,
                               const char* value) {
-  if ((expected == NULL && value != NULL) ||
-      (expected != NULL && value == NULL) ||
-      (expected != NULL && value != NULL && strcmp(expected, value) != 0)) {
+  if (V8_UNLIKELY((expected == NULL && value != NULL) ||
+                  (expected != NULL && value == NULL) ||
+                  (expected != NULL && value != NULL &&
+                   strcmp(expected, value) != 0))) {
     V8_Fatal(file, line,
              "CHECK_EQ(%s, %s) failed\n#   Expected: %s\n#   Found: %s",
              expected_source, value_source, expected, value);
   }
 }
 
 
 inline void CheckNonEqualsHelper(const char* file,
                                  int line,
                                  const char* expected_source,
                                  const char* expected,
                                  const char* value_source,
                                  const char* value) {
-  if (expected == value ||
-      (expected != NULL && value != NULL && strcmp(expected, value) == 0)) {
+  if (V8_UNLIKELY(expected == value || (expected != NULL && value != NULL &&
+                                        strcmp(expected, value) == 0))) {
     V8_Fatal(file, line, "CHECK_NE(%s, %s) failed\n#   Value: %s",
              expected_source, value_source, value);
   }
 }
 
 
 // Helper function used by the CHECK function when given pointer
 // arguments.  Should not be called directly.
 inline void CheckEqualsHelper(const char* file,
                               int line,
                               const char* expected_source,
                               const void* expected,
                               const char* value_source,
                               const void* value) {
-  if (expected != value) {
+  if (V8_UNLIKELY(expected != value)) {
     V8_Fatal(file, line,
              "CHECK_EQ(%s, %s) failed\n#   Expected: %p\n#   Found: %p",
              expected_source, value_source,
              expected, value);
   }
 }
 
 
 inline void CheckNonEqualsHelper(const char* file,
                                  int line,
                                  const char* expected_source,
                                  const void* expected,
                                  const char* value_source,
                                  const void* value) {
-  if (expected == value) {
+  if (V8_UNLIKELY(expected == value)) {
     V8_Fatal(file, line, "CHECK_NE(%s, %s) failed\n#   Value: %p",
              expected_source, value_source, value);
   }
 }
 
 
 inline void CheckNonEqualsHelper(const char* file,
                               int line,
                               const char* expected_source,
                               int64_t expected,
                               const char* value_source,
                               int64_t value) {
-  if (expected == value) {
+  if (V8_UNLIKELY(expected == value)) {
     V8_Fatal(file, line,
              "CHECK_EQ(%s, %s) failed\n#   Expected: %f\n#   Found: %f",
              expected_source, value_source, expected, value);
   }
 }
 
 
 #define CHECK_EQ(expected, value) CheckEqualsHelper(__FILE__, __LINE__, \
   #expected, expected, #value, value)
 
@@ skipping 42 matching lines @@
 
 // "Extra checks" are lightweight checks that are enabled in some release
 // builds.
 #ifdef ENABLE_EXTRA_CHECKS
 #define EXTRA_CHECK(condition) CHECK(condition)
 #else
 #define EXTRA_CHECK(condition) ((void) 0)
 #endif
 
 #endif  // V8_BASE_LOGGING_H_