Replace NULL with nullptr.

Replace NULL with nullptr.

BUG=

Committed: https://crrev.com/514272fc81a0b28a76de5fad3493b5514749733c
Cr-Commit-Position: refs/heads/master@{#313382}

[Kevin M, 2015-01-07 01:10:30]

kmarshall@chromium.org changed reviewers:
+ imcheng@google.com

[Kevin M, 2015-01-15 02:26:55]

Ping

[imcheng, 2015-01-15 19:26:44]

imcheng@chromium.org changed reviewers:
+ imcheng@chromium.org

[imcheng, 2015-01-15 19:26:45]

lgtm, you will need lgtm from an OWNERS in cast_channel.

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/cast_channel_api_unittest.cc (right):

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_channel_api_unittest.cc:61:
EXPECT_TRUE(ip_endpoint.get() != nullptr);
Can this simply be EXPECT_TRUE(ip_endpoint.get()); ?

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/cast_transport.cc (right):

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_transport.cc:398:
DCHECK(current_message_.get() == nullptr);
DCHECK(!current_message_); ?

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_transport.cc:409:
DCHECK(current_message_.get() == nullptr);
ditto

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_transport.cc:413:
DCHECK(current_message_.get() == nullptr);
ditto

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/logger.h (right):

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/logger.h:76: // If serialization or
compression failed, returns a nullptr pointer.
rm pointer

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/logger_unittest.cc (right):

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/logger_unittest.cc:260:
ASSERT_TRUE(log.get() != nullptr);
ASSERT_TRUE(log.get()); same for below.

[Kevin M, 2015-01-27 00:56:45]

kmarshall@chromium.org changed reviewers:
+ mfoltz@chromium.org

[Kevin M, 2015-01-27 00:56:46]

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/cast_channel_api_unittest.cc (right):

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_channel_api_unittest.cc:61:
EXPECT_TRUE(ip_endpoint.get() != nullptr);
On 2015/01/15 19:26:45, imcheng1 wrote:
> Can this simply be EXPECT_TRUE(ip_endpoint.get()); ?

Done.

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/cast_transport.cc (right):

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_transport.cc:398:
DCHECK(current_message_.get() == nullptr);
On 2015/01/15 19:26:45, imcheng1 wrote:
> DCHECK(!current_message_); ?

Done.

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_transport.cc:409:
DCHECK(current_message_.get() == nullptr);
On 2015/01/15 19:26:45, imcheng1 wrote:
> ditto

Done.

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_transport.cc:413:
DCHECK(current_message_.get() == nullptr);
On 2015/01/15 19:26:45, imcheng1 wrote:
> ditto

Done.

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/logger.h (right):

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/logger.h:76: // If serialization or
compression failed, returns a nullptr pointer.
On 2015/01/15 19:26:45, imcheng1 wrote:
> rm pointer

Done.

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/logger_unittest.cc (right):

https://codereview.chromium.org/843453002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/logger_unittest.cc:260:
ASSERT_TRUE(log.get() != nullptr);
On 2015/01/15 19:26:45, imcheng1 wrote:
> ASSERT_TRUE(log.get()); same for below.

Done.

[mark a. foltz, 2015-01-27 22:04:49]

lgtm

[mark a. foltz, 2015-01-27 22:04:49]

lgtm

lgtm

[Kevin M, 2015-01-27 22:36:16]

The CQ bit was checked by kmarshall@chromium.org

[commit-bot: I haz the power, 2015-01-27 22:36:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/843453002/40001

[commit-bot: I haz the power, 2015-01-27 22:41:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-27 22:42:43]

Patchset 3 (id:??) landed as
https://crrev.com/514272fc81a0b28a76de5fad3493b5514749733c
Cr-Commit-Position: refs/heads/master@{#313382}