Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: extensions/browser/api/cast_channel/logger_unittest.cc

Issue 843453002: Replace NULL with nullptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync w/master, code review feedback. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/api/cast_channel/logger.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/test/simple_test_tick_clock.h" 7 #include "base/test/simple_test_tick_clock.h"
8 #include "extensions/browser/api/cast_channel/cast_auth_util.h" 8 #include "extensions/browser/api/cast_channel/cast_auth_util.h"
9 #include "extensions/browser/api/cast_channel/logger.h" 9 #include "extensions/browser/api/cast_channel/logger.h"
10 #include "extensions/browser/api/cast_channel/logger_util.h" 10 #include "extensions/browser/api/cast_channel/logger_util.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 logger_->LogSocketChallengeReplyEvent(2, auth_result); 114 logger_->LogSocketChallengeReplyEvent(2, auth_result);
115 115
116 LastErrors last_errors = logger_->GetLastErrors(2); 116 LastErrors last_errors = logger_->GetLastErrors(2);
117 EXPECT_EQ(last_errors.event_type, proto::AUTH_CHALLENGE_REPLY); 117 EXPECT_EQ(last_errors.event_type, proto::AUTH_CHALLENGE_REPLY);
118 EXPECT_EQ(last_errors.net_return_value, net::OK); 118 EXPECT_EQ(last_errors.net_return_value, net::OK);
119 EXPECT_EQ(last_errors.challenge_reply_error_type, 119 EXPECT_EQ(last_errors.challenge_reply_error_type,
120 proto::CHALLENGE_REPLY_ERROR_CERT_PARSING_FAILED); 120 proto::CHALLENGE_REPLY_ERROR_CERT_PARSING_FAILED);
121 EXPECT_EQ(last_errors.nss_error_code, kTestNssErrorCode); 121 EXPECT_EQ(last_errors.nss_error_code, kTestNssErrorCode);
122 122
123 scoped_ptr<Log> log = GetLog(); 123 scoped_ptr<Log> log = GetLog();
124 ASSERT_TRUE(log.get() != NULL); 124 ASSERT_TRUE(log);
125 125
126 ASSERT_EQ(2, log->aggregated_socket_event_size()); 126 ASSERT_EQ(2, log->aggregated_socket_event_size());
127 { 127 {
128 const AggregatedSocketEvent& aggregated_socket_event = 128 const AggregatedSocketEvent& aggregated_socket_event =
129 log->aggregated_socket_event(0); 129 log->aggregated_socket_event(0);
130 EXPECT_EQ(1, aggregated_socket_event.id()); 130 EXPECT_EQ(1, aggregated_socket_event.id());
131 EXPECT_EQ(3, aggregated_socket_event.socket_event_size()); 131 EXPECT_EQ(3, aggregated_socket_event.socket_event_size());
132 { 132 {
133 const SocketEvent& event = aggregated_socket_event.socket_event(0); 133 const SocketEvent& event = aggregated_socket_event.socket_event(0);
134 EXPECT_EQ(EventType::CAST_SOCKET_CREATED, event.type()); 134 EXPECT_EQ(EventType::CAST_SOCKET_CREATED, event.type());
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 clock_->Advance(base::TimeDelta::FromMicroseconds(1)); 250 clock_->Advance(base::TimeDelta::FromMicroseconds(1));
251 251
252 logger_->LogSocketEventWithRv(2, EventType::SOCKET_READ, 100); 252 logger_->LogSocketEventWithRv(2, EventType::SOCKET_READ, 100);
253 clock_->Advance(base::TimeDelta::FromMicroseconds(1)); 253 clock_->Advance(base::TimeDelta::FromMicroseconds(1));
254 logger_->LogSocketEventWithRv(2, EventType::SOCKET_WRITE, 100); 254 logger_->LogSocketEventWithRv(2, EventType::SOCKET_WRITE, 100);
255 clock_->Advance(base::TimeDelta::FromMicroseconds(1)); 255 clock_->Advance(base::TimeDelta::FromMicroseconds(1));
256 logger_->LogSocketEventWithRv(2, EventType::SOCKET_WRITE, -5); 256 logger_->LogSocketEventWithRv(2, EventType::SOCKET_WRITE, -5);
257 clock_->Advance(base::TimeDelta::FromMicroseconds(1)); 257 clock_->Advance(base::TimeDelta::FromMicroseconds(1));
258 258
259 scoped_ptr<Log> log = GetLog(); 259 scoped_ptr<Log> log = GetLog();
260 ASSERT_TRUE(log.get() != NULL); 260 ASSERT_TRUE(log);
261 261
262 ASSERT_EQ(2, log->aggregated_socket_event_size()); 262 ASSERT_EQ(2, log->aggregated_socket_event_size());
263 { 263 {
264 const AggregatedSocketEvent& aggregated_socket_event = 264 const AggregatedSocketEvent& aggregated_socket_event =
265 log->aggregated_socket_event(0); 265 log->aggregated_socket_event(0);
266 EXPECT_EQ(1, aggregated_socket_event.id()); 266 EXPECT_EQ(1, aggregated_socket_event.id());
267 EXPECT_EQ(4, aggregated_socket_event.socket_event_size()); 267 EXPECT_EQ(4, aggregated_socket_event.socket_event_size());
268 EXPECT_EQ(80, aggregated_socket_event.bytes_read()); 268 EXPECT_EQ(80, aggregated_socket_event.bytes_read());
269 EXPECT_EQ(20, aggregated_socket_event.bytes_written()); 269 EXPECT_EQ(20, aggregated_socket_event.bytes_written());
270 } 270 }
271 { 271 {
272 const AggregatedSocketEvent& aggregated_socket_event = 272 const AggregatedSocketEvent& aggregated_socket_event =
273 log->aggregated_socket_event(1); 273 log->aggregated_socket_event(1);
274 EXPECT_EQ(2, aggregated_socket_event.id()); 274 EXPECT_EQ(2, aggregated_socket_event.id());
275 EXPECT_EQ(3, aggregated_socket_event.socket_event_size()); 275 EXPECT_EQ(3, aggregated_socket_event.socket_event_size());
276 EXPECT_EQ(100, aggregated_socket_event.bytes_read()); 276 EXPECT_EQ(100, aggregated_socket_event.bytes_read());
277 EXPECT_EQ(100, aggregated_socket_event.bytes_written()); 277 EXPECT_EQ(100, aggregated_socket_event.bytes_written());
278 } 278 }
279 } 279 }
280 280
281 TEST_F(CastChannelLoggerTest, TooManySockets) { 281 TEST_F(CastChannelLoggerTest, TooManySockets) {
282 for (int i = 0; i < kMaxSocketsToLog + 5; i++) { 282 for (int i = 0; i < kMaxSocketsToLog + 5; i++) {
283 logger_->LogSocketEvent(i, EventType::CAST_SOCKET_CREATED); 283 logger_->LogSocketEvent(i, EventType::CAST_SOCKET_CREATED);
284 } 284 }
285 285
286 scoped_ptr<Log> log = GetLog(); 286 scoped_ptr<Log> log = GetLog();
287 ASSERT_TRUE(log.get() != NULL); 287 ASSERT_TRUE(log);
288 288
289 ASSERT_EQ(kMaxSocketsToLog, log->aggregated_socket_event_size()); 289 ASSERT_EQ(kMaxSocketsToLog, log->aggregated_socket_event_size());
290 EXPECT_EQ(5, log->num_evicted_aggregated_socket_events()); 290 EXPECT_EQ(5, log->num_evicted_aggregated_socket_events());
291 EXPECT_EQ(5, log->num_evicted_socket_events()); 291 EXPECT_EQ(5, log->num_evicted_socket_events());
292 292
293 const AggregatedSocketEvent& aggregated_socket_event = 293 const AggregatedSocketEvent& aggregated_socket_event =
294 log->aggregated_socket_event(0); 294 log->aggregated_socket_event(0);
295 EXPECT_EQ(5, aggregated_socket_event.id()); 295 EXPECT_EQ(5, aggregated_socket_event.id());
296 } 296 }
297 297
298 TEST_F(CastChannelLoggerTest, TooManyEvents) { 298 TEST_F(CastChannelLoggerTest, TooManyEvents) {
299 for (int i = 0; i < kMaxEventsPerSocket + 5; i++) { 299 for (int i = 0; i < kMaxEventsPerSocket + 5; i++) {
300 logger_->LogSocketEvent(1, EventType::CAST_SOCKET_CREATED); 300 logger_->LogSocketEvent(1, EventType::CAST_SOCKET_CREATED);
301 clock_->Advance(base::TimeDelta::FromMicroseconds(1)); 301 clock_->Advance(base::TimeDelta::FromMicroseconds(1));
302 } 302 }
303 303
304 scoped_ptr<Log> log = GetLog(); 304 scoped_ptr<Log> log = GetLog();
305 ASSERT_TRUE(log.get() != NULL); 305 ASSERT_TRUE(log);
306 306
307 ASSERT_EQ(1, log->aggregated_socket_event_size()); 307 ASSERT_EQ(1, log->aggregated_socket_event_size());
308 EXPECT_EQ(0, log->num_evicted_aggregated_socket_events()); 308 EXPECT_EQ(0, log->num_evicted_aggregated_socket_events());
309 EXPECT_EQ(5, log->num_evicted_socket_events()); 309 EXPECT_EQ(5, log->num_evicted_socket_events());
310 310
311 const AggregatedSocketEvent& aggregated_socket_event = 311 const AggregatedSocketEvent& aggregated_socket_event =
312 log->aggregated_socket_event(0); 312 log->aggregated_socket_event(0);
313 ASSERT_EQ(kMaxEventsPerSocket, aggregated_socket_event.socket_event_size()); 313 ASSERT_EQ(kMaxEventsPerSocket, aggregated_socket_event.socket_event_size());
314 EXPECT_EQ(5, aggregated_socket_event.socket_event(0).timestamp_micros()); 314 EXPECT_EQ(5, aggregated_socket_event.socket_event(0).timestamp_micros());
315 } 315 }
316 316
317 TEST_F(CastChannelLoggerTest, Reset) { 317 TEST_F(CastChannelLoggerTest, Reset) {
318 logger_->LogSocketEvent(1, EventType::CAST_SOCKET_CREATED); 318 logger_->LogSocketEvent(1, EventType::CAST_SOCKET_CREATED);
319 319
320 scoped_ptr<Log> log = GetLog(); 320 scoped_ptr<Log> log = GetLog();
321 ASSERT_TRUE(log.get() != NULL); 321 ASSERT_TRUE(log);
322 322
323 EXPECT_EQ(1, log->aggregated_socket_event_size()); 323 EXPECT_EQ(1, log->aggregated_socket_event_size());
324 324
325 logger_->Reset(); 325 logger_->Reset();
326 326
327 log = GetLog(); 327 log = GetLog();
328 ASSERT_TRUE(log.get() != NULL); 328 ASSERT_TRUE(log);
329 329
330 EXPECT_EQ(0, log->aggregated_socket_event_size()); 330 EXPECT_EQ(0, log->aggregated_socket_event_size());
331 } 331 }
332 332
333 } // namespace cast_channel 333 } // namespace cast_channel
334 } // namespace core_api 334 } // namespace core_api
335 } // namespace extensions 335 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/api/cast_channel/logger.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698