[rAC, OSX] Use a bubble for tooltips.

[rAC, OSX] Use a bubble for tooltips.

Tooltips for requestAutocomplete should use the Chrome bubble look.

BUG=315966
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238247

[groby-ooo-7-16, 2013-11-23 03:26:10]

PTAL

[Robert Sesek, 2013-12-02 17:16:52]

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm
(right):

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm:54:
hasCheckboxTooltip = true;
nit: over-indented

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_notification_controller.h
(right):

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_notification_controller.h:16: @class
AutofillTooltipController;
nit: alphabetize

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h (right):

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h:13: @class
AutofillBubbleController;
nit: alphabetize

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h:23: :
NSViewController<AutofillTooltipDelegate> {
@private

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h:30:
@property(nonatomic, copy) NSString* message;
copy, nonatomic

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm (right):

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm:13: CGFloat
kTooltipDelay = 0.1;  // Delay time before tooltip shows/hides.
NSTimeInterval

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm:16: }
// namespace

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm:27:
@property(nonatomic, assign) id<AutofillTooltipDelegate> tooltipDelegate;
assign, nonatomic

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm:144: 
nit: extra blank line

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm
(right):

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm:15:
virtual void SetUp() {
OVERRIDE

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm:28: 
nit: extra blank lines

[groby-ooo-7-16, 2013-12-02 20:41:56]

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm
(right):

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm:54:
hasCheckboxTooltip = true;
On 2013/12/02 17:16:53, rsesek wrote:
> nit: over-indented

Done.

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_notification_controller.h
(right):

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_notification_controller.h:16: @class
AutofillTooltipController;
On 2013/12/02 17:16:53, rsesek wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h (right):

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h:13: @class
AutofillBubbleController;
On 2013/12/02 17:16:53, rsesek wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h:23: :
NSViewController<AutofillTooltipDelegate> {
On 2013/12/02 17:16:53, rsesek wrote:
> @private

Done.

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h:30:
@property(nonatomic, copy) NSString* message;
On 2013/12/02 17:16:53, rsesek wrote:
> copy, nonatomic

Done.

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm (right):

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm:13: CGFloat
kTooltipDelay = 0.1;  // Delay time before tooltip shows/hides.
On 2013/12/02 17:16:53, rsesek wrote:
> NSTimeInterval

Done.

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm:16: }
Killed namespace entirely - turns out consts at file scope always have internal
linkage.

(See e.g.
https://codereview.chromium.org/89023003/diff/1/chrome/browser/ui/cocoa/autof...
)

On 2013/12/02 17:16:53, rsesek wrote:
> // namespace

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm:27:
@property(nonatomic, assign) id<AutofillTooltipDelegate> tooltipDelegate;
On 2013/12/02 17:16:53, rsesek wrote:
> assign, nonatomic

Done.

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm:144: 
On 2013/12/02 17:16:53, rsesek wrote:
> nit: extra blank line

Done.

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm
(right):

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm:15:
virtual void SetUp() {
On 2013/12/02 17:16:53, rsesek wrote:
> OVERRIDE

Done.

https://codereview.chromium.org/84343002/diff/30001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm:28: 
On 2013/12/02 17:16:53, rsesek wrote:
> nit: extra blank lines

Done.

[groby-ooo-7-16, 2013-12-02 20:42:25]

PTAL

[Robert Sesek, 2013-12-02 21:16:19]

LGTM

[commit-bot: I haz the power, 2013-12-02 23:02:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/84343002/110001

[commit-bot: I haz the power, 2013-12-03 00:41:39]

Change committed as 238247