Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3064)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_notification_controller_unittest.mm

Issue 84343002: [rAC, OSX] Use a bubble for tooltips. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/autofill_notification_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller_unittest.mm
index 0ae4faae171a37f1256fd6c7d713a04adb2d4df2..f74cdb61ffaa9acc24c8af04c3db50f7620e9f72 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller_unittest.mm
@@ -46,12 +46,12 @@ TEST_F(AutofillNotificationControllerTest, Subviews) {
EXPECT_TRUE([[[view subviews] objectAtIndex:1] isKindOfClass:
[NSButton class]]);
EXPECT_TRUE([[[view subviews] objectAtIndex:2] isKindOfClass:
- [NSImageView class]]);
+ [NSButton class]]);
EXPECT_NSEQ([controller_ textview],
[[view subviews] objectAtIndex:0]);
EXPECT_NSEQ([controller_ checkbox],
[[view subviews] objectAtIndex:1]);
- EXPECT_NSEQ([controller_ tooltipIcon],
+ EXPECT_NSEQ([controller_ tooltipView],
[[view subviews] objectAtIndex:2]);
// Just to exercise the code path.
@@ -66,7 +66,7 @@ TEST_F(AutofillNotificationControllerTest, TextLabelOnly) {
EXPECT_FALSE([[controller_ textview] isHidden]);
EXPECT_TRUE([[controller_ checkbox] isHidden]);
- EXPECT_TRUE([[controller_ tooltipIcon] isHidden]);
+ EXPECT_TRUE([[controller_ tooltipView] isHidden]);
}
TEST_F(AutofillNotificationControllerTest, CheckboxOnly) {
@@ -78,7 +78,7 @@ TEST_F(AutofillNotificationControllerTest, CheckboxOnly) {
EXPECT_TRUE([[controller_ textview] isHidden]);
EXPECT_FALSE([[controller_ checkbox] isHidden]);
- EXPECT_TRUE([[controller_ tooltipIcon] isHidden]);
+ EXPECT_TRUE([[controller_ tooltipView] isHidden]);
}
TEST_F(AutofillNotificationControllerTest, TextLabelAndTooltip) {
@@ -90,9 +90,7 @@ TEST_F(AutofillNotificationControllerTest, TextLabelAndTooltip) {
EXPECT_FALSE([[controller_ textview] isHidden]);
EXPECT_TRUE([[controller_ checkbox] isHidden]);
- EXPECT_FALSE([[controller_ tooltipIcon] isHidden]);
- EXPECT_NSEQ(@"My very informative tooltip.",
- [[controller_ tooltipIcon] toolTip]);
+ EXPECT_FALSE([[controller_ tooltipView] isHidden]);
}
TEST_F(AutofillNotificationControllerTest, CheckboxAndTooltip) {
@@ -105,7 +103,5 @@ TEST_F(AutofillNotificationControllerTest, CheckboxAndTooltip) {
EXPECT_TRUE([[controller_ textview] isHidden]);
EXPECT_FALSE([[controller_ checkbox] isHidden]);
- EXPECT_FALSE([[controller_ tooltipIcon] isHidden]);
- EXPECT_NSEQ(@"My very informative tooltip.",
- [[controller_ tooltipIcon] toolTip]);
+ EXPECT_FALSE([[controller_ tooltipView] isHidden]);
}

Powered by Google App Engine
This is Rietveld 408576698