Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 843213003: Remove dart generator code from json schema compiler. (Closed)

Created:
5 years, 11 months ago by benwells
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dart generator code from json schema compiler. This isn't used by anything. BUG=448704 Committed: https://crrev.com/0eeb6a9a3b410797f88f487c2fe80170273f2723 Cr-Commit-Position: refs/heads/master@{#312343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2049 lines) Patch
M tools/json_schema_compiler/compiler.py View 5 chunks +2 lines, -12 lines 0 comments Download
D tools/json_schema_compiler/dart_generator.py View 1 chunk +0 lines, -763 lines 0 comments Download
D tools/json_schema_compiler/dart_generator_test.py View 1 chunk +0 lines, -81 lines 0 comments Download
D tools/json_schema_compiler/dart_test/comments.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/json_schema_compiler/dart_test/comments.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D tools/json_schema_compiler/dart_test/dictionaries.dart View 1 chunk +0 lines, -235 lines 0 comments Download
D tools/json_schema_compiler/dart_test/dictionaries.idl View 1 chunk +0 lines, -61 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_namespace.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_namespace.idl View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_type.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_type.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/json_schema_compiler/dart_test/events.dart View 1 chunk +0 lines, -282 lines 0 comments Download
D tools/json_schema_compiler/dart_test/events.idl View 1 chunk +0 lines, -56 lines 0 comments Download
D tools/json_schema_compiler/dart_test/functions.dart View 1 chunk +0 lines, -93 lines 0 comments Download
D tools/json_schema_compiler/dart_test/functions.idl View 1 chunk +0 lines, -55 lines 0 comments Download
D tools/json_schema_compiler/dart_test/operatable_type.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D tools/json_schema_compiler/dart_test/operatable_type.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D tools/json_schema_compiler/dart_test/tags.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D tools/json_schema_compiler/dart_test/tags.idl View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
5 years, 11 months ago (2015-01-20 04:07:20 UTC) #2
not at google - send to devlin
lgtm
5 years, 11 months ago (2015-01-20 18:35:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843213003/1
5 years, 11 months ago (2015-01-21 01:14:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 14:10:15 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:11:46 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0eeb6a9a3b410797f88f487c2fe80170273f2723
Cr-Commit-Position: refs/heads/master@{#312343}

Powered by Google App Engine
This is Rietveld 408576698