Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: tools/json_schema_compiler/compiler.py

Issue 843213003: Remove dart generator code from json schema compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/json_schema_compiler/dart_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/compiler.py
diff --git a/tools/json_schema_compiler/compiler.py b/tools/json_schema_compiler/compiler.py
index 0b14d293e40d5713cd6d3f98a6de358fb716acc7..0d4b264dee6615da06edc1d1c2f2eed2d518b51f 100755
--- a/tools/json_schema_compiler/compiler.py
+++ b/tools/json_schema_compiler/compiler.py
@@ -24,7 +24,6 @@ import sys
from cpp_bundle_generator import CppBundleGenerator
from cpp_generator import CppGenerator
from cpp_type_generator import CppTypeGenerator
-from dart_generator import DartGenerator
import json_schema
from cpp_namespace_environment import CppNamespaceEnvironment
from model import Model
@@ -32,14 +31,13 @@ from schema_loader import SchemaLoader
# Names of supported code generators, as specified on the command-line.
# First is default.
-GENERATORS = ['cpp', 'cpp-bundle-registration', 'cpp-bundle-schema', 'dart']
+GENERATORS = ['cpp', 'cpp-bundle-registration', 'cpp-bundle-schema']
def GenerateSchema(generator_name,
file_paths,
root,
destdir,
cpp_namespace_pattern,
- dart_overrides_dir,
impl_dir,
include_rules):
# Merge the source files into a single list of schemas.
@@ -117,11 +115,6 @@ def GenerateSchema(generator_name,
('%s.h' % filename_base, cpp_generator.h_generator),
('%s.cc' % filename_base, cpp_generator.cc_generator)
]
- elif generator_name == 'dart':
- generators = [
- ('%s.dart' % namespace.unix_name, DartGenerator(
- dart_overrides_dir))
- ]
else:
raise Exception('Unrecognised generator %s' % generator_name)
@@ -159,8 +152,6 @@ if __name__ == '__main__':
choices=GENERATORS,
help='The generator to use to build the output code. Supported values are'
' %s' % GENERATORS)
- parser.add_option('-D', '--dart-overrides-dir', dest='dart_overrides_dir',
- help='Adds custom dart from files in the given directory (Dart only).')
parser.add_option('-i', '--impl-dir', dest='impl_dir',
help='The root path of all API implementations')
parser.add_option('-I', '--include-rules',
@@ -192,7 +183,6 @@ if __name__ == '__main__':
shlex.split(opts.include_rules))
result = GenerateSchema(opts.generator, file_paths, opts.root, opts.destdir,
- opts.namespace, opts.dart_overrides_dir,
- opts.impl_dir, include_rules)
+ opts.namespace, opts.impl_dir, include_rules)
if not opts.destdir:
print result
« no previous file with comments | « no previous file | tools/json_schema_compiler/dart_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698