Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 843143002: Remove unused RuleSet flags. (Closed)

Created:
5 years, 11 months ago by rune
Modified:
5 years, 11 months ago
Reviewers:
Timothy Loh, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unused RuleSet flags. hasRightmostSelectorMatchingHTMLBasedOnRuleHash and hasMultipartSelector were not in use. Removed flags and related code. Unused after https://codereview.chromium.org/208423010 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188176

Patch Set 1 #

Patch Set 2 : isLastInArray() is in use. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M Source/core/css/RuleSet.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 1 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rune
PTAL
5 years, 11 months ago (2015-01-09 19:25:10 UTC) #2
Timothy Loh
On 2015/01/09 19:25:10, rune wrote: > PTAL lgtm
5 years, 11 months ago (2015-01-09 22:36:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843143002/20001
5 years, 11 months ago (2015-01-09 23:03:32 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 00:33:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188176

Powered by Google App Engine
This is Rietveld 408576698