Issue 208423010: Remove SelectorCheckerFastPath

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208423010: Remove SelectorCheckerFastPath (Closed)

Created:
6 years, 9 months ago by esprehn

Modified:
6 years, 9 months ago

Reviewers:
ojan, abarth-chromium

CC:
blink-reviews, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove SelectorCheckerFastPath There's no evidence that this fast path actually matters, the only difference seems to be the number of if and switch statements. If it does we should look into how we can make the regular SelectorChecker faster instead of having two modes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169993

Patch Set 1 #

Patch Set 2 : const #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -352 lines)			Patch
M	Source/core/core.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/ElementRuleCollector.cpp	View		2 chunks	+0 lines, -24 lines	0 comments	Download
M	Source/core/css/RuleSet.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/RuleSet.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download
D	Source/core/css/SelectorCheckerFastPath.h	View		1 chunk	+0 lines, -64 lines	0 comments	Download
D	Source/core/css/SelectorCheckerFastPath.cpp	View		1 chunk	+0 lines, -224 lines	0 comments	Download
M	Source/core/dom/SelectorQuery.h	View	1	3 chunks	+4 lines, -10 lines	0 comments	Download
M	Source/core/dom/SelectorQuery.cpp	View		10 chunks	+16 lines, -24 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/208423010/20001

6 years, 9 months ago (2014-03-26 00:56:02 UTC) #3

Message was sent while issue was closed.

Change committed as 169993

Expand Messages | Collapse Messages