Chromium Code Reviews

Issue 208423010: Remove SelectorCheckerFastPath (Closed)

Created:
6 years, 9 months ago by esprehn
Modified:
6 years, 9 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis
Visibility:
Public.

Description

Remove SelectorCheckerFastPath There's no evidence that this fast path actually matters, the only difference seems to be the number of if and switch statements. If it does we should look into how we can make the regular SelectorChecker faster instead of having two modes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169993

Patch Set 1 #

Patch Set 2 : const #

Unified diffs Side-by-side diffs Stats (+20 lines, -352 lines)
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments
M Source/core/css/ElementRuleCollector.cpp View 2 chunks +0 lines, -24 lines 0 comments
M Source/core/css/RuleSet.h View 2 chunks +0 lines, -2 lines 0 comments
M Source/core/css/RuleSet.cpp View 2 chunks +0 lines, -2 lines 0 comments
D Source/core/css/SelectorCheckerFastPath.h View 1 chunk +0 lines, -64 lines 0 comments
D Source/core/css/SelectorCheckerFastPath.cpp View 1 chunk +0 lines, -224 lines 0 comments
M Source/core/dom/SelectorQuery.h View 3 chunks +4 lines, -10 lines 0 comments
M Source/core/dom/SelectorQuery.cpp View 10 chunks +16 lines, -24 lines 0 comments

Messages

Total messages: 4 (0 generated)
esprehn
6 years, 9 months ago (2014-03-26 00:42:49 UTC) #1
ojan
lgtm
6 years, 9 months ago (2014-03-26 00:55:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/208423010/20001
6 years, 9 months ago (2014-03-26 00:56:02 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 01:06:13 UTC) #4
Message was sent while issue was closed.
Change committed as 169993

Powered by Google App Engine