Issue 843013005: Add checks to the marking queue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 843013005: Add checks to the marking queue (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 11 months ago

Reviewers:
Hannes Payer (out of office), ulan

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Add checks to the marking queue Hopefully we'll catch heap corruption earlier where identifying the object that holds a stale pointer. Speaking of staleness, also remove old debugging code. BUG=chromium:128415 R=ulan@chromium.org,hpayer@chromium.org LOG=n Committed: https://crrev.com/b54f00fc8e20d3f1b34273c65f7509559e7fdd89 Cr-Commit-Position: refs/heads/master@{#26095}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -4 lines)			Patch
M	src/heap/incremental-marking.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/heap/mark-compact.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843013005/1

5 years, 11 months ago (2015-01-16 10:07:34 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-16 10:39:34 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b54f00fc8e20d3f1b34273c65f7509559e7fdd89
Cr-Commit-Position: refs/heads/master@{#26095}