Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/heap/incremental-marking.cc

Issue 843013005: Add checks to the marking queue (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/heap/incremental-marking.h" 7 #include "src/heap/incremental-marking.h"
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/compilation-cache.h" 10 #include "src/compilation-cache.h"
(...skipping 637 matching lines...) Expand 10 before | Expand all | Expand 10 after
648 HeapObject* obj = marking_deque->Pop(); 648 HeapObject* obj = marking_deque->Pop();
649 649
650 // Explicitly skip one word fillers. Incremental markbit patterns are 650 // Explicitly skip one word fillers. Incremental markbit patterns are
651 // correct only for objects that occupy at least two words. 651 // correct only for objects that occupy at least two words.
652 Map* map = obj->map(); 652 Map* map = obj->map();
653 if (map == filler_map) continue; 653 if (map == filler_map) continue;
654 654
655 int size = obj->SizeFromMap(map); 655 int size = obj->SizeFromMap(map);
656 unscanned_bytes_of_large_object_ = 0; 656 unscanned_bytes_of_large_object_ = 0;
657 VisitObject(map, obj, size); 657 VisitObject(map, obj, size);
658 int delta = (size - unscanned_bytes_of_large_object_); 658 bytes_processed += size - unscanned_bytes_of_large_object_;
659 // TODO(jochen): remove after http://crbug.com/381820 is resolved.
660 CHECK_LT(0, delta);
661 bytes_processed += delta;
662 } 659 }
663 return bytes_processed; 660 return bytes_processed;
664 } 661 }
665 662
666 663
667 void IncrementalMarking::ProcessMarkingDeque() { 664 void IncrementalMarking::ProcessMarkingDeque() {
668 Map* filler_map = heap_->one_pointer_filler_map(); 665 Map* filler_map = heap_->one_pointer_filler_map();
669 MarkingDeque* marking_deque = 666 MarkingDeque* marking_deque =
670 heap_->mark_compact_collector()->marking_deque(); 667 heap_->mark_compact_collector()->marking_deque();
671 while (!marking_deque->IsEmpty()) { 668 while (!marking_deque->IsEmpty()) {
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
984 void IncrementalMarking::IncrementIdleMarkingDelayCounter() { 981 void IncrementalMarking::IncrementIdleMarkingDelayCounter() {
985 idle_marking_delay_counter_++; 982 idle_marking_delay_counter_++;
986 } 983 }
987 984
988 985
989 void IncrementalMarking::ClearIdleMarkingDelayCounter() { 986 void IncrementalMarking::ClearIdleMarkingDelayCounter() {
990 idle_marking_delay_counter_ = 0; 987 idle_marking_delay_counter_ = 0;
991 } 988 }
992 } 989 }
993 } // namespace v8::internal 990 } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/heap/mark-compact.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698