Mixed Content: Create a strict-mode Setting. [2/3]

Mixed Content: Create a strict-mode Setting. [2/3]

This is the Chromium-side of a patch introducing a strict-mode setting.
It creates a new pref, wires the pref's value up to the setting from the
first patch in the series, and creates LayoutTest hooks which the next
patch will use to test the implementation.

Patch 1: https://codereview.chromium.org/821383008/
Patch 2: [THIS PATCH]
Patch 3: https://codereview.chromium.org/841693002

BUG=442662
NOTRY=true

Committed: https://crrev.com/2fc2c4fd5b471a2eb754e6c391249854a61a1cf8
Cr-Commit-Position: refs/heads/master@{#310461}

[Mike West, 2015-01-07 12:22:32]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2015-01-07 12:22:38]

2/3.

[Mike West, 2015-01-07 12:25:39]

https://codereview.chromium.org/842643002/diff/1/chrome/common/chrome_switches.h
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/842643002/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.h:319: extern const char
kStrictMixedContentChecking[];
I only put this in chrome switches because the other "allow insecure whatever"
switches are here. I'd kinda prefer for this to be a Content-level concept.
WDYT?

[jochen (gone - plz use gerrit), 2015-01-07 13:53:23]

why do you make this a chrome pref? Unless there's some UI or something to
control it, I think directly putting teh command line value into the web prefs
is good enough (also then you don't need any chrome changes, just content)

[Mike West, 2015-01-07 13:58:26]

On 2015/01/07 13:53:23, jochen (slow) wrote:
> why do you make this a chrome pref? Unless there's some UI or something to
> control it, I think directly putting teh command line value into the web prefs
> is good enough (also then you don't need any chrome changes, just content)

I'm paving the way for discussion with UI folks about adding content settings
for things like this. Happy to drop the pref for the moment if there's a clean
way of separating things that I could add back in later.

[jochen (gone - plz use gerrit), 2015-01-07 13:59:51]

yeah, let's separate that out

[Mike West, 2015-01-07 14:34:51]

Is this more or less what you're looking for? Or would you prefer simplifying
the whole thing down to a RuntimeEnabledFeature until I convince folks that
adding a content setting isn't crazy? :)

[jochen (gone - plz use gerrit), 2015-01-07 15:20:34]

lgtm

[Mike West, 2015-01-08 04:04:09]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-01-08 04:04:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/842643002/40001

[commit-bot: I haz the power, 2015-01-08 06:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 06:05:57]

Exceeded time limit waiting for builds to trigger.

[Mike West, 2015-01-08 06:12:57]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-01-08 06:13:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/842643002/40001

[Mike West, 2015-01-08 08:27:06]

NOTRYing to get around extreme *_gpu_triggered_test slowness.

[Mike West, 2015-01-08 08:27:19]

The CQ bit was unchecked by mkwst@chromium.org

[Mike West, 2015-01-08 08:27:25]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-01-08 08:27:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/842643002/40001

[commit-bot: I haz the power, 2015-01-08 08:29:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-08 08:30:29]

Patchset 3 (id:??) landed as
https://crrev.com/2fc2c4fd5b471a2eb754e6c391249854a61a1cf8
Cr-Commit-Position: refs/heads/master@{#310461}