Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 841693002: Mixed Content: Create a strict-mode Setting. [3/3] (Closed)

Created:
5 years, 11 months ago by Mike West
Modified:
5 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@strict-setting
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mixed Content: Create a strict-mode Setting. [3/3] This patch simply adds a layout test to verify and lock-in the behavior changes from patches #1 and #2. Patch 1: https://codereview.chromium.org/821383008/ Patch 2: https://codereview.chromium.org/842643002/ Patch 3: [THIS PATCH] BUG=442662 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
A + LayoutTests/http/tests/security/mixedContent/strict-mode-via-pref-image-blocked.https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/security/mixedContent/strict-mode-via-pref-image-blocked.https-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mike West
3/3. Just a test.
5 years, 11 months ago (2015-01-07 12:22:51 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-07 13:53:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841693002/1
5 years, 11 months ago (2015-01-08 08:32:13 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-08 10:33:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841693002/1
5 years, 11 months ago (2015-01-08 11:18:10 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 12:11:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188036

Powered by Google App Engine
This is Rietveld 408576698