Issue 842503002: Merge to branch 2214 [Password Generation] Hide popup if view can not be created.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 842503002: Merge to branch 2214 [Password Generation] Hide popup if view can not be created. (Closed)

Created:
5 years, 11 months ago by Garrett Casto

Modified:
5 years, 11 months ago

Reviewers:

CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Target Ref:
refs/pending/branch-heads/2214

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge to branch 2214 [Password Generation] Hide popup if view can not be created. Fixes a crash. BUG=439618 Review URL: https://codereview.chromium.org/811563004 Cr-Commit-Position: refs/heads/master@{#309323} (cherry picked from commit 978e1ba2dcd2e4b7667b8831b2784b466ea28c87) Committed: https://chromium.googlesource.com/chromium/src/+/3a1ebba4426fd0206d63988b0d037b5d746bb5d6

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -6 lines)			Patch
	M	chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc	View		3 chunks	+16 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Garrett Casto

5 years, 11 months ago (2015-01-06 22:04:00 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3a1ebba4426fd0206d63988b0d037b5d746bb5d6.

Expand Messages | Collapse Messages