Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 811563004: [Password Generation] Hide popup if view can not be created. (Closed)

Created:
6 years ago by Garrett Casto
Modified:
6 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Hide popup if view can not be created. Fixes a crash. BUG=439618 Committed: https://crrev.com/978e1ba2dcd2e4b7667b8831b2784b466ea28c87 Cr-Commit-Position: refs/heads/master@{#309323}

Patch Set 1 #

Patch Set 2 : Tests #

Patch Set 3 : Leak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc View 1 2 3 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Garrett Casto
6 years ago (2014-12-16 21:12:38 UTC) #2
Evan Stade
lgtm
6 years ago (2014-12-16 21:17:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811563004/20001
6 years ago (2014-12-16 21:19:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/18978)
6 years ago (2014-12-16 22:37:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811563004/40001
6 years ago (2014-12-20 01:49:08 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-20 02:38:38 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-20 02:39:33 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/978e1ba2dcd2e4b7667b8831b2784b466ea28c87
Cr-Commit-Position: refs/heads/master@{#309323}

Powered by Google App Engine
This is Rietveld 408576698