Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: runtime/vm/assembler_x64.cc

Issue 842263002: Really really fix mac x64 debug build by using more fixed-length encoding and long jumps. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64.cc
===================================================================
--- runtime/vm/assembler_x64.cc (revision 42740)
+++ runtime/vm/assembler_x64.cc (working copy)
@@ -3059,7 +3059,8 @@
COMPILE_ASSERT(kHeapObjectTag == 1);
testb(dest, Immediate((kWordSize - 1) - kHeapObjectTag));
j(ZERO, &ok, Assembler::kNearJump);
- Stop("Expected heap object or Smi");
+ static const bool kFixedLengthEncoding = true;
Florian Schneider 2015/01/12 10:31:51 It does not matter here, but I think we tend not t
+ Stop("Expected heap object or Smi", kFixedLengthEncoding);
Bind(&ok);
}
@@ -3077,7 +3078,8 @@
#endif
cmpq(dest, Immediate(reinterpret_cast<uint64_t>(Object::null())));
j(EQUAL, &ok, Assembler::kNearJump);
- Stop("Expected zapped, Smi or null");
+ static const bool kFixedLengthEncoding = true;
Florian Schneider 2015/01/12 10:31:51 Same.
+ Stop("Expected zapped, Smi or null", kFixedLengthEncoding);
Bind(&ok);
}
« no previous file with comments | « no previous file | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698