runtime/vm/stub_code_x64.cc - Issue 842263002: Really really fix mac x64 debug build by using more fixed-length encoding and long jumps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 842263002: Really really fix mac x64 debug build by using more fixed-length encoding and long jumps. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_x64.cc

===================================================================

--- runtime/vm/stub_code_x64.cc (revision 42724)

+++ runtime/vm/stub_code_x64.cc (working copy)

@@ -1106,7 +1106,12 @@

Label done;

__ Bind(&init_loop);

__ cmpq(RCX, RBX);

- __ j(ABOVE_EQUAL, &done, Assembler::kNearJump);

+#if defined(DEBUG)

+ static const bool kJumpLength = Assembler::kFarJump;

+#else

+ static const bool kJumpLength = Assembler::kNearJump;

+#endif // DEBUG

+ __ j(ABOVE_EQUAL, &done, kJumpLength);

__ InitializeFieldNoBarrier(RAX, Address(RCX, 0), R12);

__ addq(RCX, Immediate(kWordSize));

__ jmp(&init_loop, Assembler::kNearJump);

« runtime/vm/assembler_x64.cc ('K') | « runtime/vm/assembler_x64.cc ('k') | no next file » | no next file with comments »