Push API: Require user visible notification, else show auto notification

chrome/browser/services/gcm/push_messaging_service_impl.h

Index: chrome/browser/services/gcm/push_messaging_service_impl.h
diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.h b/chrome/browser/services/gcm/push_messaging_service_impl.h
index 99de11693c656b28fd4f44661dc81b0877e7ac8c..1434e497dd27bd907f54f5e1e3d749e7e2a84086 100644
--- a/chrome/browser/services/gcm/push_messaging_service_impl.h
+++ b/chrome/browser/services/gcm/push_messaging_service_impl.h
@@ -80,8 +80,12 @@ class PushMessagingServiceImpl : public content::PushMessagingService,
 
   void DeliverMessageCallback(const PushMessagingApplicationId& application_id,
                               const GCMClient::IncomingMessage& message,
+                              int notification_count_before_event,
                               content::PushDeliveryStatus status);
 
+  void RequireUserVisibleUX(const PushMessagingApplicationId& application_id,

[Peter Beverloo, 2015/01/09 17:58:21]

Even though this is private, it would be great if we could add some
documentation to the method because it's not clear what it does. Something along
the lines of:

  // Developers are required to display a Web Notification in response to an
  // incoming push message in order to clarify to the user that something has
  // happened in the background. When they forget to do so, display a default
  // notification on their behalf.

[johnme, 2015/01/09 18:28:47]

Done.

+                            int notification_count_before_event);
+
   void RegisterEnd(
       const content::PushMessagingService::RegisterCallback& callback,
       const std::string& registration_id,