Push API: Require user visible notification, else show auto notification

chrome/browser/services/gcm/push_messaging_service_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_
 #define CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_
 
 #include "base/compiler_specific.h"
 #include "base/memory/weak_ptr.h"
 #include "components/gcm_driver/gcm_app_handler.h"
@@ skipping 62 matching lines @@
       const GURL& embedding_origin) override;
 
   void SetProfileForTesting(Profile* profile);
 
  private:
   void IncreasePushRegistrationCount(int add);
   void DecreasePushRegistrationCount(int subtract);
 
   void DeliverMessageCallback(const PushMessagingApplicationId& application_id,
                               const GCMClient::IncomingMessage& message,
+                              int notification_count_before_event,
                               content::PushDeliveryStatus status);
 
+  void RequireUserVisibleUX(const PushMessagingApplicationId& application_id,

[Peter Beverloo, 2015/01/09 17:58:21]

Even though this is private, it would be great if we could add some
documentation to the method because it's not clear what it does. Something along
the lines of:

  // Developers are required to display a Web Notification in response to an
  // incoming push message in order to clarify to the user that something has
  // happened in the background. When they forget to do so, display a default
  // notification on their behalf.

[johnme, 2015/01/09 18:28:47]

Done.

+                            int notification_count_before_event);
+
   void RegisterEnd(
       const content::PushMessagingService::RegisterCallback& callback,
       const std::string& registration_id,
       content::PushRegistrationStatus status);
 
   void DidRegister(
       const content::PushMessagingService::RegisterCallback& callback,
       const std::string& registration_id,
       GCMClient::Result result);
 
@@ skipping 23 matching lines @@
   int push_registration_count_;
 
   base::WeakPtrFactory<PushMessagingServiceImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PushMessagingServiceImpl);
 };
 
 }  // namespace gcm
 
 #endif  // CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_