Chromium Code Reviews

Unified Diff: sdk/lib/_internal/pub/lib/src/source/path.dart

Issue 84223002: Make the override warnings prettier. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: sdk/lib/_internal/pub/lib/src/source/path.dart
diff --git a/sdk/lib/_internal/pub/lib/src/source/path.dart b/sdk/lib/_internal/pub/lib/src/source/path.dart
index af752d674308146e3c0417f5957fafb1b77940b4..76892e1e6528a26573858f4073dff48b9382476a 100644
--- a/sdk/lib/_internal/pub/lib/src/source/path.dart
+++ b/sdk/lib/_internal/pub/lib/src/source/path.dart
@@ -113,6 +113,16 @@ class PathSource extends Source {
return description;
}
+ /// Converts a parsed relative path to its original relative form.
+ String formatDescription(String containingPath, description) {
+ var sourcePath = description["path"];
+ if (description["relative"]) {
+ sourcePath = path.relative(description['path'], from: containingPath);
nweiz 2013/11/26 21:14:46 I think this should be relative to the pwd, not [c
Bob Nystrom 2013/11/26 22:29:38 I tried that, but it feels and looks wrong to me.
nweiz 2013/11/27 01:11:39 How about this: if [containingPath] isn't [path.cu
Bob Nystrom 2013/12/03 19:10:55 The string returned by this is already used in a l
+ }
+
+ return sourcePath;
+ }
+
/// Ensures that [description] is a valid path description and returns a
/// normalized path to the package.
///

Powered by Google App Engine