Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: sdk/lib/_internal/pub/lib/src/source.dart

Issue 84223002: Make the override warnings prettier. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/source.dart
diff --git a/sdk/lib/_internal/pub/lib/src/source.dart b/sdk/lib/_internal/pub/lib/src/source.dart
index 676e1a6640913cddddacae0fda050926886078ed..859dd0affccb93dbd493467dbff62a0825b939cd 100644
--- a/sdk/lib/_internal/pub/lib/src/source.dart
+++ b/sdk/lib/_internal/pub/lib/src/source.dart
@@ -228,12 +228,21 @@ abstract class Source {
}
/// When a [LockFile] is serialized, it uses this method to get the
- /// [description] in the right format. [containingPath] references the
- /// containing directory of the root package.
+ /// [description] in the right format.
+ ///
+ /// [containingPath] references the containing directory of the root package.
dynamic serializeDescription(String containingPath, description) {
return description;
}
+ /// When a package [description] is shown to the user, this is called to
+ /// convert it into a human-friendly form.
+ ///
+ /// [containingPath] references the containing directory of the root package.
nweiz 2013/11/26 21:14:46 "references" -> "is" Also mention the default val
Bob Nystrom 2013/11/26 22:29:38 Done.
+ String formatDescription(String containingPath, description) {
+ return description;
nweiz 2013/11/26 21:14:46 description.toString()
Bob Nystrom 2013/11/26 22:29:38 Done.
+ }
+
/// Returns whether or not [description1] describes the same package as
/// [description2] for this source. This method should be light-weight. It
/// doesn't need to validate that either package exists.

Powered by Google App Engine
This is Rietveld 408576698