Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 842063003: Add glBindBufferRange to GPU command buffer. (Closed)

Created:
5 years, 11 months ago by Zhenyao Mo
Modified:
5 years, 11 months ago
Reviewers:
bajones, piman
CC:
chromium-reviews, Ken Russell (switch to Gerrit), piman+watch_chromium.org, no sievers, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@buffer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add glBindBufferRange to GPU command buffer. BUG=429053 TEST=gpu bots Committed: https://crrev.com/58897d385de2cdb4c65c8ea64388c8363fdf11ea Cr-Commit-Position: refs/heads/master@{#311209}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : With fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+528 lines, -287 lines) Patch
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 5 chunks +27 lines, -19 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 2 chunks +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 1 chunk +26 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +59 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +17 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +249 lines, -248 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 1 2 2 chunks +29 lines, -17 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 2 chunks +17 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Zhenyao Mo
bajones: please review others: FYI This one is very similar to glBindBufferBase
5 years, 11 months ago (2015-01-09 01:37:06 UTC) #2
bajones
lgtm
5 years, 11 months ago (2015-01-09 23:49:09 UTC) #3
Zhenyao Mo
Rebased this CL based on https://codereview.chromium.org/846943002/ piman: could you take a look?
5 years, 11 months ago (2015-01-13 00:32:55 UTC) #6
piman
lgtm
5 years, 11 months ago (2015-01-13 00:55:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842063003/60001
5 years, 11 months ago (2015-01-13 01:27:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842063003/60001
5 years, 11 months ago (2015-01-13 04:24:54 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 11 months ago (2015-01-13 04:26:06 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 04:27:11 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/58897d385de2cdb4c65c8ea64388c8363fdf11ea
Cr-Commit-Position: refs/heads/master@{#311209}

Powered by Google App Engine
This is Rietveld 408576698