Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: Source/core/rendering/RenderPart.cpp

Issue 842033003: Cleanup RemotePlatformLayer when disconnecting RemoteFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/core/rendering/compositing/CompositedLayerMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderPart.cpp
diff --git a/Source/core/rendering/RenderPart.cpp b/Source/core/rendering/RenderPart.cpp
index 33f88c93b1e1551309a59f26fe37c25b975defc4..eb8ad23df8264a220c721e7c734ebd0aa6d49969 100644
--- a/Source/core/rendering/RenderPart.cpp
+++ b/Source/core/rendering/RenderPart.cpp
@@ -132,7 +132,7 @@ bool RenderPart::requiresAcceleratedCompositing() const
return false;
HTMLFrameOwnerElement* element = toHTMLFrameOwnerElement(node());
- if (element->contentFrame() && element->contentFrame()->remotePlatformLayer())
+ if (element->contentFrame() && element->contentFrame()->isRemoteFrame())
return true;
if (Document* contentDocument = element->contentDocument()) {
@@ -166,10 +166,6 @@ bool RenderPart::nodeAtPoint(const HitTestRequest& request, HitTestResult& resul
if (!widget() || !widget()->isFrameView() || !request.allowsChildFrameContent())
return nodeAtPointOverWidget(request, result, locationInContainer, accumulatedOffset, action);
- // FIXME: Until RemoteFrames use RemoteFrameViews, we need an explicit check here.
- if (toFrameView(widget())->frame().isRemoteFrameTemporary())
kenrb 2015/01/23 18:31:02 I am surprised if this does not break input events
lfg 2015/02/03 03:43:46 RemoteFrameViews return false to isFrameView(), so
- return nodeAtPointOverWidget(request, result, locationInContainer, accumulatedOffset, action);
-
FrameView* childFrameView = toFrameView(widget());
RenderView* childRoot = childFrameView->renderView();
« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/core/rendering/compositing/CompositedLayerMapping.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698