Source/core/page/EventHandler.cpp - Issue 842033003: Cleanup RemotePlatformLayer when disconnecting RemoteFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 842033003: Cleanup RemotePlatformLayer when disconnecting RemoteFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index 850bdba7fad1bcaa7d325a5bc7ea2e38d98a7b02..1311b46d776a09ca4f8b11dd31f61cb50b1bd5ad 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -981,10 +981,6 @@ static LocalFrame* subframeForTargetNode(Node* node)

if (!renderer || !renderer->isRenderPart())

return nullptr;

- // FIXME: This explicit check is needed only until RemoteFrames have RemoteFrameViews.

- if (isHTMLFrameElementBase(node) && toHTMLFrameElementBase(node)->contentFrame() && toHTMLFrameElementBase(node)->contentFrame()->isRemoteFrameTemporary())

- return nullptr;

Widget* widget = toRenderPart(renderer)->widget();

if (!widget || !widget->isFrameView())

return nullptr;

« no previous file with comments | « Source/core/frame/RemoteFrame.cpp ('k') | Source/core/rendering/RenderPart.cpp » ('j') | Source/core/rendering/RenderPart.cpp » ('J')