Change QUIC's RTO implementation. Protected by FLAGS_quic_use_new_rto.

Change QUIC's RTO implementation. Protected by FLAGS_quic_use_new_rto.

Decides whether to invoke SendAlgorithmInterface's
OnRetransmissionTimeout after an ack has been received instead of
pro-actively invoking it and then having to revert it.

Merge internal change: 83625311


Fix a minor QUIC bug when both quic_use_new_rto and
quic_rto_uses_last_sent were enabled, a spurious retransmission didn't
expire the SRTT.

Merge internal change: 83966746
R=ianswett@google.com, rch@chromium.org

[Ian Swett, 2015-01-14 15:39:04]

I would suggest setting the flag to true now, since it's a feature flag.

https://codereview.chromium.org/841603005/diff/1/net/quic/quic_flags.cc
File net/quic/quic_flags.cc (right):

https://codereview.chromium.org/841603005/diff/1/net/quic/quic_flags.cc#newco...
net/quic/quic_flags.cc:82: bool FLAGS_quic_use_new_rto = false;
I would suggest setting this to true.

[ramant (doing other things), 2015-01-14 19:50:41]

https://codereview.chromium.org/841603005/diff/1/net/quic/quic_flags.cc
File net/quic/quic_flags.cc (right):

https://codereview.chromium.org/841603005/diff/1/net/quic/quic_flags.cc#newco...
net/quic/quic_flags.cc:82: bool FLAGS_quic_use_new_rto = false;
On 2015/01/14 15:39:04, Ian Swett wrote:
> I would suggest setting this to true.

Hi Ian,
  Will enable this flag after we have made sure all the tests with both
FLAGS_quic_rto_uses_last_sent and FLAGS_quic_use_new_rto being true (based on
the conersation we had over email).

[ramant (doing other things), 2015-01-14 21:25:43]

Patchset #2 (id:20001) has been deleted

[ramant (doing other things), 2015-01-14 21:28:31]

Hi Ian and Ryan,
  Merged Ian's internal change 83966746 into this CL and enabled
FLAGS_quic_use_new_rto.

  PTAL.

https://codereview.chromium.org/841603005/diff/1/net/quic/quic_flags.cc
File net/quic/quic_flags.cc (right):

https://codereview.chromium.org/841603005/diff/1/net/quic/quic_flags.cc#newco...
net/quic/quic_flags.cc:82: bool FLAGS_quic_use_new_rto = false;
On 2015/01/14 19:50:41, ramant wrote:
> On 2015/01/14 15:39:04, Ian Swett wrote:
> > I would suggest setting this to true.
> 
> Hi Ian,
>   Will enable this flag after we have made sure all the tests with both
> FLAGS_quic_rto_uses_last_sent and FLAGS_quic_use_new_rto being true (based on
> the conersation we had over email).

Enabled the flag. Thanks Ian for the fix.

[Ryan Hamilton, 2015-01-14 21:39:12]

lgtm.  ian?

[Ian Swett, 2015-01-14 21:41:48]

The CQ bit was checked by ianswett@google.com

[Ian Swett, 2015-01-14 21:41:48]

lgtm

[commit-bot: I haz the power, 2015-01-14 21:42:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/841603005/40001

[ramant (doing other things), 2015-01-14 21:44:46]

The CQ bit was unchecked by rtenneti@chromium.org

[ramant (doing other things), 2015-01-14 21:45:59]

On 2015/01/14 21:42:41, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/841603005/40001

Hi Ian and Ryan,
  Committing this change as part of  https://codereview.chromium.org/849123003
  which merges removal of version 21 and this change. Unchecked the commit flag.

thanks
raman