Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 849123003: Land Recent QUIC Changes. (Closed)

Created:
5 years, 11 months ago by ramant (doing other things)
Modified:
5 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett, Jana, alyssar, rjshade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Change QUIC's RTO implementation. Protected by FLAGS_quic_use_new_rto. Decides whether to invoke SendAlgorithmInterface's OnRetransmissionTimeout after an ack has been received instead of pro-actively invoking it and then having to revert it. Fix a minor QUIC bug when both quic_use_new_rto and quic_rto_uses_last_sent were enabled, a spurious retransmission didn't expire the SRTT. Merge internal change: 83625311, 83966746 https://codereview.chromium.org/841603005/ Remove unused original transmission stats from QuicAckNotifier. No behavior change. Merge internal change: 83598791 https://codereview.chromium.org/798873005/ Removing quic version 21 Merge internal change: 83551025 https://codereview.chromium.org/786953009/ Fixes typo, changing OnSpuriousPacketRetransmition to OnSpuriousPacketRetransmission. Merge internal change: 83546153 https://codereview.chromium.org/837273004/ Adds an alarm for sending a QUIC FEC packet. This CL adds an alarm for sending an FEC packet. The alarm is based on the connection's SRTT, and is set when the first FEC protected packet in an FEC group is sent. This alarm puts some time between the sending of an FEC protected packet and the corresponding FEC packet, to reduce the probability of both these packets getting dropped in the network. Merge internal change: 83543120 https://codereview.chromium.org/839163003/ Tell the QUIC AckNotifierManager about packets on serialization, rather than when successfully sent. Protected by ENABLEd FLAGS_quic_ack_notifier_informed_on_serialized. Merge internal change: 83525991 https://codereview.chromium.org/854463003/ R=rch@chromium.org BUG=448688 Committed: https://crrev.com/5d9c02ca6f59328fe2191422fa950301187a36ff Cr-Commit-Position: refs/heads/master@{#311789}

Patch Set 1 #

Patch Set 2 : Fix the data race in bug 448688 #

Patch Set 3 : Removed extra blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1085 lines, -418 lines) Patch
M net/quic/quic_ack_notifier.h View 2 chunks +4 lines, -12 lines 0 comments Download
M net/quic/quic_ack_notifier.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M net/quic/quic_ack_notifier_test.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M net/quic/quic_connection.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 7 chunks +40 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 48 chunks +370 lines, -199 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/quic_packet_creator.h View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.h View 4 chunks +16 lines, -3 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 6 chunks +46 lines, -22 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 19 chunks +211 lines, -48 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 4 chunks +9 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 9 chunks +61 lines, -7 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 9 chunks +242 lines, -28 lines 0 comments Download
M net/quic/quic_server_session.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_session.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_packet_generator_peer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_packet_generator_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +4 lines, -5 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 4 chunks +12 lines, -8 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ramant (doing other things)
5 years, 11 months ago (2015-01-14 21:44:50 UTC) #1
ramant (doing other things)
On 2015/01/14 21:44:50, ramant wrote: Hi Ryan, Working on a fix for the race in ...
5 years, 11 months ago (2015-01-15 01:21:58 UTC) #2
ramant (doing other things)
Hi Ryan, Verified pausing and resuming the server (similar to other unittests) fixes the race. ...
5 years, 11 months ago (2015-01-15 02:35:46 UTC) #4
Ryan Hamilton
lgtm
5 years, 11 months ago (2015-01-15 20:27:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849123003/60001
5 years, 11 months ago (2015-01-15 21:29:49 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 11 months ago (2015-01-16 00:46:01 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:48:19 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5d9c02ca6f59328fe2191422fa950301187a36ff
Cr-Commit-Position: refs/heads/master@{#311789}

Powered by Google App Engine
This is Rietveld 408576698