Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: media/base/android/media_source_player.h

Issue 841453006: Fix WeakPtrFactory members in Android media classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/android/media_source_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_source_player.h
diff --git a/media/base/android/media_source_player.h b/media/base/android/media_source_player.h
index e0922b6aed5a7085ea51c66d3a989dd469ee3778..5ef684ea9346103c3e943182506d272f31194760 100644
--- a/media/base/android/media_source_player.h
+++ b/media/base/android/media_source_player.h
@@ -273,9 +273,9 @@ class MEDIA_EXPORT MediaSourcePlayer : public MediaPlayerAndroid,
bool prerolling_;
// Weak pointer passed to media decoder jobs for callbacks.
+ base::WeakPtr<MediaSourcePlayer> weak_this_;
// NOTE: Weak pointers must be invalidated before all other member variables.
base::WeakPtrFactory<MediaSourcePlayer> weak_factory_;
- base::WeakPtr<MediaSourcePlayer> weak_this_;
DISALLOW_COPY_AND_ASSIGN(MediaSourcePlayer);
};
« no previous file with comments | « content/renderer/media/android/media_source_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698