Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 841263002: MIPS: remove immediate constraint within CompareAndSwap. (Closed)

Created:
5 years, 11 months ago by paul.l...
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: remove immediate constraint within CompareAndSwap. Improper use of immediate constraint is slightly non-optimal with gcc/gnu-as but causes breakage with clang. BUG= Committed: https://crrev.com/eb68d6fe13f13b0697dd2b4ff00df1d7c997669e Cr-Commit-Position: refs/heads/master@{#26016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/base/atomicops_internals_mips64_gcc.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/base/atomicops_internals_mips_gcc.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
paul.l...
PTAL.
5 years, 11 months ago (2015-01-09 02:17:54 UTC) #2
paul.l...
PTAL, this change needs v8-team reviewers ....
5 years, 11 months ago (2015-01-09 15:31:09 UTC) #4
balazs.kilvady
LGTM
5 years, 11 months ago (2015-01-09 15:38:46 UTC) #5
Jakob Kummerow
rubberstamp LGTM
5 years, 11 months ago (2015-01-09 19:13:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841263002/1
5 years, 11 months ago (2015-01-09 19:47:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 20:12:23 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 20:12:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb68d6fe13f13b0697dd2b4ff00df1d7c997669e
Cr-Commit-Position: refs/heads/master@{#26016}

Powered by Google App Engine
This is Rietveld 408576698