Issue 841173004: Makes ViewportParameterListener an optional parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 841173004: Makes ViewportParameterListener an optional parameter. (Closed)

Created:
5 years, 11 months ago by qsr

Modified:
5 years, 11 months ago

Reviewers:
blundell

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Makes ViewportParameterListener an optional parameter. https://codereview.chromium.org/816913004 made this parameter mandatory, which breaks mojo:sample_app R=blundell@chromium.org CC=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c4eec928a4f5d612e530170b19d8f3a81640f1bb

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/services/gpu/public/interfaces/gpu.mojom	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

qsr

5 years, 11 months ago (2015-01-09 14:45:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c4eec928a4f5d612e530170b19d8f3a81640f1bb (presubmit successful).

Expand Messages | Collapse Messages