Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 816913004: Review nullability in the gpu and geometry interfaces. (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher
Modified:
5 years, 11 months ago
Reviewers:
jamesr, blundell
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M mojo/services/geometry/public/interfaces/geometry.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/gpu/public/interfaces/command_buffer.mojom View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/gpu/public/interfaces/gpu.mojom View 1 chunk +4 lines, -4 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
Elliot Glaysher
Prompted by our conversation earlier over coffee.
5 years, 11 months ago (2015-01-06 21:36:33 UTC) #2
jamesr
lgtm thanks, none of these can be usefully null
5 years, 11 months ago (2015-01-06 21:39:44 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 11 months ago (2015-01-06 21:46:59 UTC) #6
Elliot Glaysher
Committed patchset #1 (id:1) manually as 94eab58c3258e1238d4c9b97df5f209e91386848 (presubmit successful).
5 years, 11 months ago (2015-01-06 21:52:54 UTC) #7
jamesr
https://codereview.chromium.org/816913004/diff/1/mojo/services/gpu/public/interfaces/gpu.mojom File mojo/services/gpu/public/interfaces/gpu.mojom (right): https://codereview.chromium.org/816913004/diff/1/mojo/services/gpu/public/interfaces/gpu.mojom#newcode15 mojo/services/gpu/public/interfaces/gpu.mojom:15: ViewportParameterListener listener); this broke mojo:sample_app. This field is valid ...
5 years, 11 months ago (2015-01-08 23:16:29 UTC) #8
blundell
lgtm
5 years, 11 months ago (2015-01-09 14:43:43 UTC) #10
blundell
5 years, 11 months ago (2015-01-09 14:46:00 UTC) #11
Message was sent while issue was closed.
On 2015/01/09 14:43:43, blundell wrote:
> lgtm

oops, that was meant for a different cl (exercise for the reader: guess which ;)

Powered by Google App Engine
This is Rietveld 408576698