Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 840973002: Make skydb just a ctl-style helper (e.g. apachectl) (Closed)

Created:
5 years, 11 months ago by eseidel
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium, ojan
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make skydb just a ctl-style helper (e.g. apachectl) This makes it much easier to work with a device where we don't expect a persistent commandline session. Prompt no longer actually makes a prompt but rather just runs an http server. This is just a v1 patch. It doesn't work with android yet and it isn't smart enough to allow you to run more than one copy of prompt.cc at the same time (since you can't control the port it listens on). If you have a second copy of prompt runnning (or anything else bound to port 7777) it will just crash. We could make this a lot better, including splitting out the pid-file tracking for sky_server into sky_server instead of having skydb manage it. R=ojan@chromium.org, abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/5d6b0da4dad573fb9319911f5a0535181b7df7b6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix stop help #

Patch Set 3 : Fix load comand #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -107 lines) Patch
M sky/tools/debugger/prompt/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/tools/debugger/prompt/prompt.cc View 6 chunks +68 lines, -78 lines 0 comments Download
M sky/tools/skydb View 1 2 4 chunks +116 lines, -27 lines 0 comments Download
M sky/tools/skypy/skyserver.py View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
5 years, 11 months ago (2015-01-07 23:37:07 UTC) #1
ojan
lgtm. I didn't do a terribly thorough review, but this all seems fine. https://codereview.chromium.org/840973002/diff/1/sky/tools/skydb File ...
5 years, 11 months ago (2015-01-07 23:49:54 UTC) #3
eseidel
5 years, 11 months ago (2015-01-08 21:01:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5d6b0da4dad573fb9319911f5a0535181b7df7b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698