Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2055)

Unified Diff: sky/tools/skypy/skyserver.py

Issue 840973002: Make skydb just a ctl-style helper (e.g. apachectl) (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Fix load comand Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tools/skydb ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/skypy/skyserver.py
diff --git a/sky/tools/skypy/skyserver.py b/sky/tools/skypy/skyserver.py
index bddea9e0ab9c03f09cc077fcd4cc4972d5f4cedd..b90846e44571991d741697408e5d76564137140d 100644
--- a/sky/tools/skypy/skyserver.py
+++ b/sky/tools/skypy/skyserver.py
@@ -26,7 +26,7 @@ class SkyServer(object):
'download_sky_server'))
return os.path.join(paths.src_root, 'out', 'downloads', 'sky_server')
- def __enter__(self):
+ def start(self):
if self._port_in_use(self.port):
logging.warn(
'Port %s already in use, assuming custom sky_server started.' %
@@ -41,11 +41,18 @@ class SkyServer(object):
str(self.port),
]
self.server = subprocess.Popen(server_command)
+ return self.server.pid
- def __exit__(self, exc_type, exc_value, traceback):
+ def stop(self):
if self.server:
self.server.terminate()
+ def __enter__(self):
+ self.start()
+
+ def __exit__(self, exc_type, exc_value, traceback):
+ self.stop()
+
def path_as_url(self, path):
return self.url_for_path(self.port, self.root, path)
« no previous file with comments | « sky/tools/skydb ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698