Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 840953003: [turbofan] Correctify representation changes to bit. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Correctify representation changes to bit. TEST=cctest/test-representation-change,unittests,mjsunit/compiler/regress-bit-number-constant R=jarin@chromium.org Committed: https://crrev.com/fec1bba85223a3a32182e4874be46b355f6df89e Cr-Commit-Position: refs/heads/master@{#25987}

Patch Set 1 #

Patch Set 2 : mjsunit test #

Total comments: 2

Patch Set 3 : std::isnan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -65 lines) Patch
M src/compiler/change-lowering.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/change-lowering.cc View 2 chunks +27 lines, -5 lines 0 comments Download
M src/compiler/js-graph.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/representation-change.h View 1 2 6 chunks +45 lines, -25 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.h View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +16 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +16 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 7 chunks +41 lines, -17 lines 0 comments Download
M test/mjsunit/compiler/regress-bit-number-constant.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +22 lines, -1 line 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-08 08:10:37 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-08 08:12:43 UTC) #2
Jarin
lgtm. https://codereview.chromium.org/840953003/diff/20001/src/compiler/representation-change.h File src/compiler/representation-change.h (right): https://codereview.chromium.org/840953003/diff/20001/src/compiler/representation-change.h#newcode305 src/compiler/representation-change.h:305: if (value == 0.0 || value != value) ...
5 years, 11 months ago (2015-01-08 09:18:14 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/840953003/diff/20001/src/compiler/representation-change.h File src/compiler/representation-change.h (right): https://codereview.chromium.org/840953003/diff/20001/src/compiler/representation-change.h#newcode305 src/compiler/representation-change.h:305: if (value == 0.0 || value != value) return ...
5 years, 11 months ago (2015-01-08 09:20:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840953003/40001
5 years, 11 months ago (2015-01-08 09:20:31 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-08 09:48:37 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 09:48:53 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fec1bba85223a3a32182e4874be46b355f6df89e
Cr-Commit-Position: refs/heads/master@{#25987}

Powered by Google App Engine
This is Rietveld 408576698