Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/compiler/verifier.cc

Issue 840953003: [turbofan] Correctify representation changes to bit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: std::isnan Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/compiler/test-representation-change.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <deque> 7 #include <deque>
8 #include <queue> 8 #include <queue>
9 #include <sstream> 9 #include <sstream>
10 #include <string> 10 #include <string>
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
605 } 605 }
606 case IrOpcode::kChangeFloat64ToTagged: { 606 case IrOpcode::kChangeFloat64ToTagged: {
607 // Number /\ UntaggedFloat64 -> Number /\ Tagged 607 // Number /\ UntaggedFloat64 -> Number /\ Tagged
608 // TODO(neis): Activate once ChangeRepresentation works in typer. 608 // TODO(neis): Activate once ChangeRepresentation works in typer.
609 // Type* from =Type::Intersect(Type::Number(), Type::UntaggedFloat64()); 609 // Type* from =Type::Intersect(Type::Number(), Type::UntaggedFloat64());
610 // Type* to = Type::Intersect(Type::Number(), Type::Tagged()); 610 // Type* to = Type::Intersect(Type::Number(), Type::Tagged());
611 // CheckValueInputIs(node, 0, from)); 611 // CheckValueInputIs(node, 0, from));
612 // CheckUpperIs(node, to)); 612 // CheckUpperIs(node, to));
613 break; 613 break;
614 } 614 }
615 case IrOpcode::kChangeBitToBool: {
616 // Boolean /\ UntaggedInt1 -> Boolean /\ TaggedPtr
617 // TODO(neis): Activate once ChangeRepresentation works in typer.
618 // Type* from = Type::Intersect(Type::Boolean(), Type::UntaggedInt1());
619 // Type* to = Type::Intersect(Type::Boolean(), Type::TaggedPtr());
620 // CheckValueInputIs(node, 0, from));
621 // CheckUpperIs(node, to));
622 break;
623 }
615 case IrOpcode::kChangeBoolToBit: { 624 case IrOpcode::kChangeBoolToBit: {
616 // Boolean /\ TaggedPtr -> Boolean /\ UntaggedInt1 625 // Boolean /\ TaggedPtr -> Boolean /\ UntaggedInt1
617 // TODO(neis): Activate once ChangeRepresentation works in typer. 626 // TODO(neis): Activate once ChangeRepresentation works in typer.
618 // Type* from = Type::Intersect(Type::Boolean(), Type::TaggedPtr()); 627 // Type* from = Type::Intersect(Type::Boolean(), Type::TaggedPtr());
619 // Type* to = Type::Intersect(Type::Boolean(), Type::UntaggedInt1()); 628 // Type* to = Type::Intersect(Type::Boolean(), Type::UntaggedInt1());
620 // CheckValueInputIs(node, 0, from)); 629 // CheckValueInputIs(node, 0, from));
621 // CheckUpperIs(node, to)); 630 // CheckUpperIs(node, to));
622 break; 631 break;
623 } 632 }
624 case IrOpcode::kChangeBitToBool: { 633 case IrOpcode::kChangeWord32ToBit: {
625 // Boolean /\ UntaggedInt1 -> Boolean /\ TaggedPtr 634 // TODO(rossberg): Check.
626 // TODO(neis): Activate once ChangeRepresentation works in typer. 635 CheckValueInputIs(node, 0, Type::Integral32());
627 // Type* from = Type::Intersect(Type::Boolean(), Type::UntaggedInt1()); 636 break;
628 // Type* to = Type::Intersect(Type::Boolean(), Type::TaggedPtr()); 637 }
629 // CheckValueInputIs(node, 0, from)); 638 case IrOpcode::kChangeWord64ToBit: {
630 // CheckUpperIs(node, to)); 639 // TODO(rossberg): Check.
631 break; 640 break;
632 } 641 }
633 642
634 case IrOpcode::kLoadField: 643 case IrOpcode::kLoadField:
635 // Object -> fieldtype 644 // Object -> fieldtype
636 // TODO(rossberg): activate once machine ops are typed. 645 // TODO(rossberg): activate once machine ops are typed.
637 // CheckValueInputIs(node, 0, Type::Object()); 646 // CheckValueInputIs(node, 0, Type::Object());
638 // CheckUpperIs(node, Field(node).type)); 647 // CheckUpperIs(node, Field(node).type));
639 break; 648 break;
640 case IrOpcode::kLoadBuffer: 649 case IrOpcode::kLoadBuffer:
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
979 // Check inputs for all nodes in the block. 988 // Check inputs for all nodes in the block.
980 for (size_t i = 0; i < block->NodeCount(); i++) { 989 for (size_t i = 0; i < block->NodeCount(); i++) {
981 Node* node = block->NodeAt(i); 990 Node* node = block->NodeAt(i);
982 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1); 991 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1);
983 } 992 }
984 } 993 }
985 } 994 }
986 } 995 }
987 } 996 }
988 } // namespace v8::internal::compiler 997 } // namespace v8::internal::compiler
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/compiler/test-representation-change.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698