components/signin/ios/browser/profile_oauth2_token_service_ios.mm - Issue 840813009: Enable strict-virtual-specifiers for iOS builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/ios/browser/profile_oauth2_token_service_ios.mm

Issue 840813009: Enable strict-virtual-specifiers for iOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/ios/browser/profile_oauth2_token_service_ios.mm

diff --git a/components/signin/ios/browser/profile_oauth2_token_service_ios.mm b/components/signin/ios/browser/profile_oauth2_token_service_ios.mm

index aa9de2ac22859bf37c3919d1a76911a202c0e0d7..5ff5d4a22172688cc62ed1d897126cda120f9434 100644

--- a/components/signin/ios/browser/profile_oauth2_token_service_ios.mm

+++ b/components/signin/ios/browser/profile_oauth2_token_service_ios.mm

@@ -61,13 +61,13 @@ class SSOAccessTokenFetcher : public OAuth2AccessTokenFetcher {

SSOAccessTokenFetcher(OAuth2AccessTokenConsumer* consumer,

ios::ProfileOAuth2TokenServiceIOSProvider* provider,

const std::string account_id);

- virtual ~SSOAccessTokenFetcher();

+ ~SSOAccessTokenFetcher() override;

- virtual void Start(const std::string& client_id,

- const std::string& client_secret,

- const std::vector<std::string>& scopes) override;

+ void Start(const std::string& client_id,

+ const std::string& client_secret,

+ const std::vector<std::string>& scopes) override;

- virtual void CancelRequest() override;

+ void CancelRequest() override;

// Handles an access token response.

void OnAccessTokenResponse(NSString* token,