Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2163)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding better comment from Charlie. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index fbc5206f1f90af2ef4534942ae83bfe8d38a3774..5c7c93514c01282c36ca086f5e9b80311549fd87 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -79,8 +79,12 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
virtual void AboutToNavigateRenderView(
RenderViewHost* render_view_host) {}
- // This method is invoked right after the navigation was initiated.
- virtual void NavigateToPendingEntry(
+ // This method is invoked after the browser process starts a navigation to a
+ // pending NavigationEntry. It is not called for renderer-initiated
+ // navigations unless they are sent to the browser process via OpenURL. It may
+ // be called multiple times for a given navigation, such as a typed URL
+ // followed by a cross-process client or server redirect.
+ virtual void DidStartNavigationToPendingEntry(
const GURL& url,
NavigationController::ReloadType reload_type) {}
« no previous file with comments | « content/browser/web_contents/web_contents_impl_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698