Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: content/browser/web_contents/web_contents_impl_browsertest.cc

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding better comment from Charlie. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl_browsertest.cc
diff --git a/content/browser/web_contents/web_contents_impl_browsertest.cc b/content/browser/web_contents/web_contents_impl_browsertest.cc
index 48cba05f8f4591e2276966a44876c980c2218024..b06a62884df85c1a134b80d842b63efaab56bd7c 100644
--- a/content/browser/web_contents/web_contents_impl_browsertest.cc
+++ b/content/browser/web_contents/web_contents_impl_browsertest.cc
@@ -135,7 +135,7 @@ class RenderViewSizeObserver : public WebContentsObserver {
rwhv_create_size_ = rvh->GetView()->GetViewBounds().size();
}
- virtual void NavigateToPendingEntry(
+ virtual void DidStartNavigationToPendingEntry(
const GURL& url,
NavigationController::ReloadType reload_type) OVERRIDE {
ResizeWebContentsView(shell_, wcv_new_size_, false);
@@ -288,8 +288,9 @@ IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest,
// RenderWidgetHostView is created at specified size.
init_size.Enlarge(size_insets.width(), size_insets.height());
EXPECT_EQ(init_size, observer.rwhv_create_size());
- // RenderViewSizeObserver resizes WebContentsView in NavigateToPendingEntry,
- // so both WebContentsView and RenderWidgetHostView adopt this new size.
+ // RenderViewSizeObserver resizes WebContentsView in
+ // DidStartNavigationToPendingEntry, so both WebContentsView and
+ // RenderWidgetHostView adopt this new size.
new_size.Enlarge(size_insets.width(), size_insets.height());
EXPECT_EQ(new_size,
shell()->web_contents()->GetRenderWidgetHostView()->GetViewBounds().
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698