chrome/browser/favicon/favicon_tab_helper.h - Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding better comment from Charlie. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/favicon/favicon_tab_helper.h

diff --git a/chrome/browser/favicon/favicon_tab_helper.h b/chrome/browser/favicon/favicon_tab_helper.h

index a5ef1ae2fd1f198a738976d08623f37a9145372a..b8255a66b848523b23d9081049e42006b97989ce 100644

--- a/chrome/browser/favicon/favicon_tab_helper.h

+++ b/chrome/browser/favicon/favicon_tab_helper.h

@@ -84,7 +84,7 @@ class FaviconTabHelper : public content::WebContentsObserver,

friend class content::WebContentsUserData<FaviconTabHelper>;

// content::WebContentsObserver overrides.

- virtual void NavigateToPendingEntry(

+ virtual void DidStartNavigationToPendingEntry(

const GURL& url,

content::NavigationController::ReloadType reload_type) OVERRIDE;

virtual void DidNavigateMainFrame(

« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »