Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding better comment from Charlie. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 int http_status_code, 77 int http_status_code,
78 const GURL& image_url, 78 const GURL& image_url,
79 const std::vector<SkBitmap>& bitmaps, 79 const std::vector<SkBitmap>& bitmaps,
80 const std::vector<gfx::Size>& original_bitmap_sizes); 80 const std::vector<gfx::Size>& original_bitmap_sizes);
81 81
82 private: 82 private:
83 explicit FaviconTabHelper(content::WebContents* web_contents); 83 explicit FaviconTabHelper(content::WebContents* web_contents);
84 friend class content::WebContentsUserData<FaviconTabHelper>; 84 friend class content::WebContentsUserData<FaviconTabHelper>;
85 85
86 // content::WebContentsObserver overrides. 86 // content::WebContentsObserver overrides.
87 virtual void NavigateToPendingEntry( 87 virtual void DidStartNavigationToPendingEntry(
88 const GURL& url, 88 const GURL& url,
89 content::NavigationController::ReloadType reload_type) OVERRIDE; 89 content::NavigationController::ReloadType reload_type) OVERRIDE;
90 virtual void DidNavigateMainFrame( 90 virtual void DidNavigateMainFrame(
91 const content::LoadCommittedDetails& details, 91 const content::LoadCommittedDetails& details,
92 const content::FrameNavigateParams& params) OVERRIDE; 92 const content::FrameNavigateParams& params) OVERRIDE;
93 93
94 Profile* profile_; 94 Profile* profile_;
95 bool should_fetch_icons_; 95 bool should_fetch_icons_;
96 96
97 scoped_ptr<FaviconHandler> favicon_handler_; 97 scoped_ptr<FaviconHandler> favicon_handler_;
98 98
99 // Handles downloading touchicons. It is NULL if 99 // Handles downloading touchicons. It is NULL if
100 // browser_defaults::kEnableTouchIcon is false. 100 // browser_defaults::kEnableTouchIcon is false.
101 scoped_ptr<FaviconHandler> touch_icon_handler_; 101 scoped_ptr<FaviconHandler> touch_icon_handler_;
102 102
103 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper); 103 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper);
104 }; 104 };
105 105
106 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 106 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698