Minor clean-ups and rename

pkg/analysis_server/lib/plugin/plugin.dart

Index: pkg/analysis_server/lib/plugin/plugin.dart
diff --git a/pkg/analysis_server/lib/plugin/plugin.dart b/pkg/analysis_server/lib/plugin/plugin.dart
index e48550fc4d46c043533135105b00b4f2cf6031ff..8000ecb4cee9d91a2b678ffa3d45a830b5848b93 100644
--- a/pkg/analysis_server/lib/plugin/plugin.dart
+++ b/pkg/analysis_server/lib/plugin/plugin.dart
@@ -5,15 +5,6 @@
 library analysis_server.plugin.plugin;
 
 /**
- * A function used by a plugin to validate an [extension] to a extension point.
- *
- * An [ExtensionError] should be thrown if the [extension] is not valid for the
- * extension point, such as an [extension] that does not implement the required
- * interface.
- */
-typedef void ExtensionValidator(Object extension);
-
-/**
  * A function used to register the given [extension] to the extension point with
  * the given unique [identifier].
  *
@@ -33,7 +24,16 @@ typedef void RegisterExtension(String identifier, Object extension);
  * with the same simple identifier.
  */
 typedef ExtensionPoint RegisterExtensionPoint(String identifier,
-    [ExtensionValidator validator]);
+    [ValidateExtension validator]);

[scheglov, 2015/01/12 16:17:50]

Just a question: Should this parameter also be renamed to "validateExtension"?

[Brian Wilkerson, 2015/01/12 16:35:03]

Good catch. Done.

+
+/**
+ * A function used by a plugin to validate an [extension] to a extension point.
+ *
+ * An [ExtensionError] should be thrown if the [extension] is not valid for the
+ * extension point, such as an [extension] that does not implement the required
+ * interface.
+ */
+typedef void ValidateExtension(Object extension);
 
 /**
  * An exception indicating that an error occurred while attempting to register