Minor clean-ups and rename

pkg/analysis_server/lib/plugin/plugin.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis_server.plugin.plugin;
 
 /**
- * A function used by a plugin to validate an [extension] to a extension point.
- *
- * An [ExtensionError] should be thrown if the [extension] is not valid for the
- * extension point, such as an [extension] that does not implement the required
- * interface.
- */
-typedef void ExtensionValidator(Object extension);
-
-/**
  * A function used to register the given [extension] to the extension point with
  * the given unique [identifier].
  *
  * An [ExtensionError] will be thrown if the [extension] is not appropriate
  * for the extension point, such as an [extension] that does not implement the
  * required interface.
  */
 typedef void RegisterExtension(String identifier, Object extension);
 
 /**
  * A function used to register an extension point with the given simple
  * [identifier]. If given, the [validator] will be used to validate extensions
  * to the extension point.
  *
  * An [ExtensionError] will be thrown if the extension point cannot be
  * registered, such as when a plugin attempts to define two extension points
  * with the same simple identifier.
  */
 typedef ExtensionPoint RegisterExtensionPoint(String identifier,
-    [ExtensionValidator validator]);
+    [ValidateExtension validator]);

[scheglov, 2015/01/12 16:17:50]

Just a question: Should this parameter also be renamed to "validateExtension"?

[Brian Wilkerson, 2015/01/12 16:35:03]

Good catch. Done.

+
+/**
+ * A function used by a plugin to validate an [extension] to a extension point.
+ *
+ * An [ExtensionError] should be thrown if the [extension] is not valid for the
+ * extension point, such as an [extension] that does not implement the required
+ * interface.
+ */
+typedef void ValidateExtension(Object extension);
 
 /**
  * An exception indicating that an error occurred while attempting to register
  * either an extension or an extension point.
  *
  * Clients are not expected to subtype this class.
  */
 class ExtensionError implements Exception {
   /**
    * The message describing the error that occurred.
@@ skipping 74 matching lines @@
   static String buildUniqueIdentifier(Plugin plugin, String simpleIdentifier) =>
       join(plugin.uniqueIdentifier, simpleIdentifier);
 
   /**
    * Return an identifier created by joining the [pluginIdentifier] and the
    * [simpleIdentifier].
    */
   static String join(String pluginIdentifier, String simpleIdentifier) =>
       '$pluginIdentifier.$simpleIdentifier';
 }