Issue 8404008: Also build SkMatrix44 on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8404008: Also build SkMatrix44 on mac (Closed)

Created:
9 years, 1 month ago by piman

Modified:
9 years, 1 month ago

Reviewers:
Nico, sky

CC:
chromium-reviews, sky

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Also build SkMatrix44 on mac It's needed to land https://bugs.webkit.org/show_bug.cgi?id=70431 BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107458

Patch Set 2 : sort #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	skia/skia.gyp	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM (I'm not an OWNER). http://codereview.chromium.org/8404008/diff/1/skia/skia.gyp File skia/skia.gyp (right): http://codereview.chromium.org/8404008/diff/1/skia/skia.gyp#newcode499 skia/skia.gyp:499: '../third_party/skia/include/utils/SkMatrix44.h', nit: sort (meaning ...

9 years, 1 month ago (2011-10-26 21:54:28 UTC) #2

piman

http://codereview.chromium.org/8404008/diff/1/skia/skia.gyp File skia/skia.gyp (right): http://codereview.chromium.org/8404008/diff/1/skia/skia.gyp#newcode499 skia/skia.gyp:499: '../third_party/skia/include/utils/SkMatrix44.h', On 2011/10/26 21:54:28, sky wrote: > nit: sort ...

9 years, 1 month ago (2011-10-26 21:57:12 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8404008/3

9 years, 1 month ago (2011-10-26 21:57:32 UTC) #5

Change committed as 107458

Expand Messages | Collapse Messages

Issue 8404008: Also build SkMatrix44 on mac (Closed)

Description

Patch Set 1 #

Patch Set 2 : sort #

Messages