Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 840343006: Temporarily add a workaround for findbugs. (Closed)

Created:
5 years, 11 months ago by nyquist
Modified:
5 years, 11 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily add a workaround for findbugs. After a clobber build triggered by the landmine from https://codereview.chromium.org/793203002 revealed an issue with the bots that they do not build all the targets they need. This caused the Android Builder (dbg) to break on the findbugs step: https://chromegw.corp.google.com/i/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/72080 This temporarily removes the known bugs for files that are currently not built. BUG=None NOTRY=true Committed: https://crrev.com/790b64ba7f5343b6b99c97e8deaa635e1e9422d0 Cr-Commit-Position: refs/heads/master@{#311616}

Patch Set 1 #

Patch Set 2 : merge in changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nyquist
cjhopman: PTAL
5 years, 11 months ago (2015-01-15 02:23:16 UTC) #2
nyquist
sorry, patch set 1 was based on old head. merged in newest now in patch ...
5 years, 11 months ago (2015-01-15 02:28:51 UTC) #3
cjhopman
lgtm
5 years, 11 months ago (2015-01-15 02:29:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840343006/20001
5 years, 11 months ago (2015-01-15 02:29:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-15 02:30:55 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 02:31:54 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/790b64ba7f5343b6b99c97e8deaa635e1e9422d0
Cr-Commit-Position: refs/heads/master@{#311616}

Powered by Google App Engine
This is Rietveld 408576698