Issue 840003002: Reland 'Move libc++ and libc++abi to buildtools.'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 840003002: Reland 'Move libc++ and libc++abi to buildtools.' (Closed)

Created:
5 years, 11 months ago by Michael Achenbach

Modified:
5 years, 11 months ago

Reviewers:
Alexander Potapenko, jochen (gone - plz use gerrit), earthdok

Base URL:
https://chromium.googlesource.com/chromium/buildtools/@master

Target Ref:
refs/heads/master

Visibility:
Public.

Reland 'Move libc++ and libc++abi to buildtools.' Same as https://codereview.chromium.org/816463004 using a third_party directory. BUG=443987 R=jochen@chromium.org Committed: 451dcd05a5b34936f5be67b2472cd63aaa508401

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+225 lines, -0 lines)			Patch
M	.DEPS.git	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	.gitignore	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	DEPS	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A	third_party/libc++/OWNERS	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	third_party/libc++/README.chromium	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	third_party/libc++/libc++.gyp	View	1	1 chunk	+117 lines, -0 lines	0 comments	Download
A	third_party/libc++abi/OWNERS	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	third_party/libc++abi/README.chromium	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	third_party/libc++abi/libc++abi.gyp	View	1	1 chunk	+60 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Michael Achenbach

PTAL. Relands in a third_party directory to auto-whitelist the licenses for the android licence check. ...

5 years, 11 months ago (2015-01-08 11:17:54 UTC) #2

jochen (gone - plz use gerrit)

5 years, 11 months ago (2015-01-08 12:59:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
451dcd05a5b34936f5be67b2472cd63aaa508401 (presubmit successful).