Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 816463004: Move libc++ and libc++abi to buildtools. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
Base URL:
https://chromium.googlesource.com/chromium/buildtools/@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move libc++ and libc++abi to buildtools. BUG=443987 R=earthdok@chromium.org, glider@chromium.org, jochen@chromium.org Committed: ea47835ce3308cd2a33a759cd8136a2c4fe982c0

Patch Set 1 #

Patch Set 2 : Add gitignore #

Total comments: 1

Patch Set 3 : Review - added .DEPS.git #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -0 lines) Patch
M .DEPS.git View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M .gitignore View 1 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
A libc++/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A libc++/README.chromium View 1 chunk +13 lines, -0 lines 0 comments Download
A libc++/libc++.gyp View 1 chunk +117 lines, -0 lines 1 comment Download
A libc++abi/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A libc++abi/README.chromium View 1 chunk +13 lines, -0 lines 0 comments Download
A libc++abi/libc++abi.gyp View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Michael Achenbach
PTAL
6 years ago (2014-12-19 12:36:21 UTC) #3
Alexander Potapenko
Will this affect any of the existing bots/checkouts? LGTM otherwise
6 years ago (2014-12-19 12:40:13 UTC) #4
Michael Achenbach
On 2014/12/19 12:40:13, Alexander Potapenko wrote: > Will this affect any of the existing bots/checkouts? ...
6 years ago (2014-12-19 12:47:46 UTC) #5
earthdok
https://codereview.chromium.org/816463004/diff/20001/DEPS File DEPS (left): https://codereview.chromium.org/816463004/diff/20001/DEPS#oldcode8 DEPS:8: "git_url": "https://chromium.googlesource.com", the comment in this file says: "The ...
6 years ago (2014-12-19 17:42:06 UTC) #6
Michael Achenbach
On 2014/12/19 17:42:06, earthdok wrote: > https://codereview.chromium.org/816463004/diff/20001/DEPS > File DEPS (left): > > https://codereview.chromium.org/816463004/diff/20001/DEPS#oldcode8 > ...
6 years ago (2014-12-22 11:14:53 UTC) #7
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/816463004/diff/40001/libc++/libc++.gyp File libc++/libc++.gyp (right): https://codereview.chromium.org/816463004/diff/40001/libc++/libc++.gyp#newcode1 libc++/libc++.gyp:1: # Copyright 2013 The Chromium Authors. All rights ...
6 years ago (2014-12-22 14:35:07 UTC) #8
earthdok
lgtm
6 years ago (2014-12-22 14:38:51 UTC) #9
jochen (gone - plz use gerrit)
6 years ago (2014-12-23 08:46:45 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ea47835ce3308cd2a33a759cd8136a2c4fe982c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698