Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 839743003: debugger: SW rasterize the picture only when it changes (Closed)

Created:
5 years, 11 months ago by Kimmo Kinnunen
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@debugcanvas-stateless-draw-01-no-resize
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

debugger: SW rasterize the picture only when it changes Rasterize the picture only when it changes, not every time raster widget paints itself. Removes include SkForceLinking.h while organizing the SkDebuggerGUI.cpp includes. This is part of the work trying to remove bugs that come from SkDebugCanvas stateful draw. Part of the state comes from some optimization that this tries to reproduce in a different way. Committed: https://skia.googlesource.com/skia/+/cfdc0e3fee69694e0f6b083d8455665b2a810589

Patch Set 1 #

Patch Set 2 : update image immediately when overdraw is clicked #

Patch Set 3 : overdraw while paused #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : rowbytes #

Total comments: 1

Patch Set 6 : address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -82 lines) Patch
M debugger/QT/SkCanvasWidget.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.cpp View 1 2 3 4 5 9 chunks +22 lines, -27 lines 0 comments Download
M debugger/QT/SkDrawCommandGeometryWidget.cpp View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M debugger/QT/SkGLWidget.h View 1 chunk +1 line, -1 line 0 comments Download
M debugger/QT/SkGLWidget.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M debugger/QT/SkRasterWidget.h View 3 chunks +5 lines, -16 lines 0 comments Download
M debugger/QT/SkRasterWidget.cpp View 1 2 3 4 1 chunk +48 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kimmo Kinnunen
This is the first patch of the unreviewed changes
5 years, 11 months ago (2015-01-07 12:40:55 UTC) #2
robertphillips
lgtm + nits https://codereview.chromium.org/839743003/diff/60001/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.chromium.org/839743003/diff/60001/debugger/QT/SkDebuggerGUI.cpp#newcode394 debugger/QT/SkDebuggerGUI.cpp:394: fPausedRow = fListWidget.currentRow(); this-> ? https://codereview.chromium.org/839743003/diff/80001/debugger/QT/SkDebuggerGUI.cpp ...
5 years, 11 months ago (2015-01-13 14:33:14 UTC) #3
Kimmo Kinnunen
https://codereview.chromium.org/839743003/diff/60001/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.chromium.org/839743003/diff/60001/debugger/QT/SkDebuggerGUI.cpp#newcode394 debugger/QT/SkDebuggerGUI.cpp:394: fPausedRow = fListWidget.currentRow(); On 2015/01/13 14:33:13, robertphillips wrote: > ...
5 years, 11 months ago (2015-01-14 06:37:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839743003/100001
5 years, 11 months ago (2015-01-14 06:39:04 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 06:49:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/cfdc0e3fee69694e0f6b083d8455665b2a810589

Powered by Google App Engine
This is Rietveld 408576698